Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issue where x86_64 architecture Windows systems could not emulate running Linux programs (dev branch). #1504

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

MuziStudio
Copy link

The main issue was that the alias for amd64 (x86_64) was missing in ql.host.arch, resulting in ql.host.arch being None. This caused an early return at ql_open_flag_mapping (const_mapping.py) without executing ret |= host_flags['O_BINARY'].value, leading to a binary truncation issue. This problem only occurs on the dev branch; the code structure in the master branch is different and does not have this issue.

Checklist

Which kind of PR do you create?

  • This PR only contains minor fixes.
  • This PR contains major feature update.
  • This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • The new code conforms to Qiling Framework naming convention.
  • The imports are arranged properly.
  • Essential comments are added.
  • The reference of the new code is pointed out.

Extra tests?

  • No extra tests are needed for this PR.
  • I have added enough tests for this PR.
  • Tests will be added after some discussion and review.

Changelog?

  • This PR doesn't need to update Changelog.
  • Changelog will be updated after some proper review.
  • Changelog has been updated in my PR.

Target branch?

  • The target branch is dev branch.

One last thing


@elicn
Copy link
Member

elicn commented Oct 29, 2024

Good catch!
Thanks for contributing the fix.

(don't mind the failed tests indications, it is not related to your code)

@xwings
Copy link
Member

xwings commented Nov 25, 2024

Hey.

Thanks!

@xwings
Copy link
Member

xwings commented Nov 25, 2024

Will merge for now while waiting for the new unicorn fix

@xwings xwings merged commit 64083f2 into qilingframework:dev Nov 25, 2024
0 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants