Move to the current API of qiskit-nature #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the lint issues, but the gates like `rlx` are still not recognized for non obvious reasons.
|
|
eggerdj
requested changes
Jan 15, 2024
Comment on lines
+4
to
+6
| qiskit-terra>= 0.45.1 | ||
| qiskit-nature>=0.7.1 | ||
| qiskit-aer>=0.8.0 |
LaurinFischer
requested changes
Jan 16, 2024
Co-authored-by: Laurin Fischer <[email protected]>
Co-authored-by: Laurin Fischer <[email protected]>
|
@eggerdj I think that the comments should now be taken into account and we are again ready for review. |
eggerdj
approved these changes
Jan 16, 2024
LaurinFischer
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This attempts to fix #87 and most likely also #88
Details and comments
However, we have to jump from the syntax of 0.4 to the syntax of 0.7 for
qiskit-natureand this seems to be a fairly major shift. I think that I might have found most of the operators, but some problems and questions remain:I think that I might have found most of the operators, but some problems and questions remain:
SparseLabelOpis the new name ofSecondQuantizedOp? Not sure what has to be changed to make it work.register_lengthseems to not exist anymore and had to be updated tonum_spin_orbitalsornum_spins.'Gate rlx has no defined generator'. No idea why.