Skip to content
This repository has been archived by the owner on Dec 8, 2024. It is now read-only.

Per-feature kernel widths #113

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Conversation

somnambWl
Copy link

  • Functions for computing Gaussian and Laplacian kernels with per-feature different kernel widths
  • Helper functions for orienting in BoB representation
  • A bit changed names variables in functions generating SLATM, but functionality should stay the same

@somnambWl somnambWl changed the title Develop Per-feature kernel widths Jun 25, 2019
Copy link
Member

@andersx andersx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Kuba! Can you also add an example how to use the new kernels to one of the .rst files in the docs folder, also we need a test that it runs, so we can check that it doesn't fail sometime in the future. Can you add a file in the test/ dir as well?

@somnambWl
Copy link
Author

You are welcome :)
Sure, I will do it.

@somnambWl
Copy link
Author

Hello, I have added one file with six new tests and a block as an example to the documentation.
I was not sure if I should run all the cells in the notebook or not, so I cleared all outputs and commited without them.
I also did not notice there was an update for the dev branch, so the last commit should be just clear merge with it.

Copy link
Member

@andersx andersx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the automated build fails with the pull-request! The test looks good otherwise, so I'll merge as soon as the test is fixed. Seems like a missing import in the test file.

https://travis-ci.org/qmlcode/qml/jobs/551285968

Copy link
Member

@andersx andersx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check the status of the build here: #113 (review)

@somnambWl
Copy link
Author

It didn't find a path to directory with helper functions. I have tried to add it to init file, I hope it passes now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants