-
Notifications
You must be signed in to change notification settings - Fork 85
Per-feature kernel widths #113
base: develop
Are you sure you want to change the base?
Conversation
somnambWl
commented
Jun 25, 2019
- Functions for computing Gaussian and Laplacian kernels with per-feature different kernel widths
- Helper functions for orienting in BoB representation
- A bit changed names variables in functions generating SLATM, but functionality should stay the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Kuba! Can you also add an example how to use the new kernels to one of the .rst files in the docs folder, also we need a test that it runs, so we can check that it doesn't fail sometime in the future. Can you add a file in the test/ dir as well?
You are welcome :) |
Hello, I have added one file with six new tests and a block as an example to the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the automated build fails with the pull-request! The test looks good otherwise, so I'll merge as soon as the test is fixed. Seems like a missing import in the test file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can check the status of the build here: #113 (review)
It didn't find a path to directory with helper functions. I have tried to add it to init file, I hope it passes now. |