Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Manual cherry-pick of patch originally reviewed on https://chromium-review.googlesource.com/c/v8/v8/+/5872631: Merged: [wasm] Do not inline wrappers with 'ref extern' parameter type This was introduced in https://crrev.com/c/4212394. The wrapper would need to test for null and throw a type error but doesn't do that correctly. (The test case added only tested that a null check happens either in the wrapper or in the cast instruction because the test case was trying to test both cases without duplicating too much which was a bad design choice.) For simplicity, just disallow inlining of wrappers with parameters typed 'ref extern'. (Users should use `externref` aka 'ref null extern' instead anyways as the non-nullability doesn't add any benefits.) (cherry picked from commit 3eee872739ac3523af126d7f25a623c18f5bee39) Bug: 366635354 Change-Id: I58deec223e9c01c5292239eebee895febc880215 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5872631 Auto-Submit: Matthias Liedtke <[email protected]> Commit-Queue: Jakob Kummerow <[email protected]> Reviewed-by: Jakob Kummerow <[email protected]> Cr-Commit-Position: refs/branch-heads/13.0@{#2} Cr-Branched-From: 4be854bd71ea878a25b236a27afcecffa2e29360-refs/heads/13.0.245@{#1} Cr-Branched-From: 1f5183f7ad6cca21029fd60653d075730c644432-refs/heads/main@{#96103} Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/597950 Reviewed-by: Michal Klocek <[email protected]>
- Loading branch information