This repository has been archived by the owner on Dec 31, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Viper2k4,
This PR should help with #42: perhaps as a coincidence, I just found out that I got an exception when an emulator is connected to adb, like this:
I've fixed that, added a unit test for the case and also made sure the
CreateFromAdbData
method includes the invalid data if an exception is thrown.Can you let me know whether this fixes the issue for you, or if the issue still reproduces, can you amend #42 and attach the updated error message + stack trace?
Thanks!
PS: I'm looking to do a new release on NuGet soon, after I've completed #43 .
@bartsaintgermain Can you review and approve?