Skip to content
This repository has been archived by the owner on Dec 31, 2022. It is now read-only.

Add support for emulator devices #44

Merged
merged 1 commit into from
Jun 9, 2016
Merged

Conversation

qmfrederik
Copy link
Contributor

Hi @Viper2k4,

This PR should help with #42: perhaps as a coincidence, I just found out that I got an exception when an emulator is connected to adb, like this:

>adb.exe devices
List of devices attached
emulator-5586   host

I've fixed that, added a unit test for the case and also made sure the CreateFromAdbData method includes the invalid data if an exception is thrown.

Can you let me know whether this fixes the issue for you, or if the issue still reproduces, can you amend #42 and attach the updated error message + stack trace?

Thanks!

PS: I'm looking to do a new release on NuGet soon, after I've completed #43 .

@bartsaintgermain Can you review and approve?

@codecov-io
Copy link

Current coverage is 85.07%

Merging #44 into master will increase coverage by 7.06%

  1. 3 files (not in diff) in ...pAdbClient/Receivers were modified. more
    • Partials -2
    • Hits +2
  2. 3 files (not in diff) in SharpAdbClient/Logs were modified. more
    • Misses +7
    • Partials -6
    • Hits +23
  3. 10 files (not in diff) in ...lient/DeviceCommands were modified. more
    • Misses -2
    • Partials -24
    • Hits +39
  4. 21 files (not in diff) in SharpAdbClient were modified. more
    • Misses +7
    • Partials -71
    • Hits +162
@@           master        #44   diff @@
========================================
  Files          52         52          
  Lines        1596       1741   +145   
  Methods         0          0          
  Branches      228        237     +9   
========================================
+ Hits         1245       1481   +236   
- Misses        248        260    +12   
+ Partials      103          0   -103   

Powered by Codecov. Last updated by 60de289...b57ed1e

@bartsaintgermain bartsaintgermain merged commit 3446df8 into master Jun 9, 2016
@qmfrederik qmfrederik deleted the issues/42-device-name branch August 31, 2016 21:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants