Refactor AST into standalone library #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricoferris
force-pushed
the
pf341-AST
branch
from
4b48a64 to
03d4733
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for the PR where we purely execute using the AST this PR refactors the AST into a standalone library. This meant moving
Shark.Block(which was very Markdown focused) intoShark_ast.Ast.Block.Raw. To ease this transition the code is almost identical but I can imagine making theRaw.tmore "raw" and thenShark.Blockbeing more markdown focused.Other things moved to like the AST dot renderer.
I don't really expect a review ((there's no new code here)) -- but just a thumbs up for the general idea and happy to answer questions @mdales ^^