Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes word_to_word event file creation for line event structure #246

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

derNarr
Copy link
Member

@derNarr derNarr commented Nov 28, 2023

Changes proposed in this pull request:

  • improves preprocessing

@derNarr derNarr requested a review from MariaHei November 28, 2023 09:36
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (891197c) 84.94% compared to head (d9475eb) 83.75%.

Files Patch % Lines
pyndl/preprocess.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
- Coverage   84.94%   83.75%   -1.19%     
==========================================
  Files           9        9              
  Lines        1408     1410       +2     
==========================================
- Hits         1196     1181      -15     
- Misses        212      229      +17     
Flag Coverage Δ
unittests 83.75% <66.66%> (-1.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@derNarr derNarr merged commit be6c481 into main Nov 28, 2023
8 checks passed
@derNarr derNarr deleted the improve-preprocess branch November 28, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants