Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect YamlConfigSource (#367) #368

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix: respect YamlConfigSource (#367) #368

merged 1 commit into from
Oct 8, 2024

Conversation

mapuci
Copy link

@mapuci mapuci commented Oct 6, 2024

Issue: #367

Fix is trivial so I didn't write any test :)
I can write it, just tell me where to put it...

  • in a new module called helm-kubernetes-minimal-yaml
  • or
  • I add quarkus-config-yaml extension and a simple test inside helm-kubernetes-minimal?

@mapuci mapuci requested a review from a team as a code owner October 6, 2024 19:07
@mapuci mapuci mentioned this pull request Oct 6, 2024
Closed
Sgitario
Sgitario requested changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@Sgitario Sgitario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the fix!
Yes, a new module called helm-kubernetes-minimal-yaml would work for me +1

@mapuci mapuci requested a review from Sgitario October 7, 2024 19:54
@mapuci
Copy link
Author

mapuci commented Oct 8, 2024

Formatting error, I force pushed again

@Sgitario Sgitario merged commit 252c815 into quarkiverse:main Oct 8, 2024
3 checks passed
@Sgitario Sgitario linked an issue Oct 8, 2024 that may be closed by this pull request
mapSystemProperties ignores YamlConfigSource #367
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sgitario Sgitario Sgitario approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mapSystemProperties ignores YamlConfigSource
2 participants
@mapuci @Sgitario