ArC: prevent duplicate bean discovery & detect duplicate bean identifiers

[Ladicek]

Fixes #37493

[mkouba]

It's a pity we can't test this somehow...

[Ladicek]

True 🤷

[Ladicek]

I mean, here's what I did locally to verify this is doing what I expected. I changed the condition from > 1 to >= 1 and mvn clean package on a tiny project that I have produced this output:

[ERROR] Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project logging: Failed to build quarkus application: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[ERROR]         [error]: Build step io.quarkus.arc.deployment.ArcProcessor#generateResources threw an exception: jakarta.enterprise.inject.spi.DeploymentException: 
[ERROR] ================================================================================
[ERROR] Multiple beans with the same identifier found!
[ERROR] ----------------------------------------------
[ERROR] This is an internal error. Please report a bug and attach the following listing.
[ERROR] 
[ERROR] w-h7_3ByeruxggBr2_bKpojNWbo -> 1 beans:
[ERROR] - CLASS bean [types=[java.lang.Object, cz.ladicek.quarkus.tiny.logging.MyService], qualifiers=[@Default, @Any], target=cz.ladicek.quarkus.tiny.logging.MyService]
[ERROR] wVC3YOXZT3tJyRk5d2ZlcsWOyH4 -> 1 beans:
[ERROR] - CLASS bean [types=[cz.ladicek.quarkus.tiny.logging.MyLoggingFilter, java.util.logging.Filter, java.lang.Object], qualifiers=[@Default, @Any], target=cz.ladicek.quarkus.tiny.logging.MyLoggingFilter]
[ERROR] vmlVrSfe_RSd4mIFvYr3iOrqX5U -> 1 beans:
[ERROR] - CLASS bean [types=[io.quarkus.arc.impl.DefaultAsyncObserverExceptionHandler, io.quarkus.arc.AsyncObserverExceptionHandler, java.lang.Object], qualifiers=[@Default, @Any], target=io.quarkus.arc.impl.DefaultAsyncObserverExceptionHandler]
[ERROR] c7JBSkuQ1C2M2pz0aBMoQPtOQ5Y -> 1 beans:
[ERROR] - SYNTHETIC bean [types=[java.lang.String[], java.lang.Object], qualifiers=[@Any, @io.quarkus.runtime.annotations.CommandLineArguments], target=n/a]
[ERROR] sFcr9mrnyYy49t0Q7Q7gcCprles -> 1 beans:
[ERROR] - CLASS bean [types=[io.quarkus.arc.runtime.ConfigStaticInitValues, java.lang.Object], qualifiers=[@Default, @Any], target=io.quarkus.arc.runtime.ConfigStaticInitValues]
[ERROR] ================================================================================
[ERROR] 
[ERROR]         at io.quarkus.arc.processor.BeanDeployment.validateBeans(BeanDeployment.java:1607)
[ERROR]         at io.quarkus.arc.processor.BeanDeployment.validate(BeanDeployment.java:485)
[ERROR]         at io.quarkus.arc.processor.BeanProcessor.validate(BeanProcessor.java:169)
[ERROR]         at io.quarkus.arc.deployment.ArcProcessor.validate(ArcProcessor.java:474)
[ERROR]         at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[ERROR]         at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
[ERROR]         at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[ERROR]         at java.base/java.lang.reflect.Method.invoke(Method.java:568)
[ERROR]         at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:849)
[ERROR]         at io.quarkus.builder.BuildContext.run(BuildContext.java:256)
[ERROR]         at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
[ERROR]         at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513)
[ERROR]         at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538)
[ERROR]         at java.base/java.lang.Thread.run(Thread.java:840)
[ERROR]         at org.jboss.threads.JBossThread.run(JBossThread.java:501)

[Ladicek]

OK, this is interesting. MP Fault Tolerance TCK fails with:

================================================================================
Multiple beans with the same identifier found!
----------------------------------------------
This is an internal error. Please report a bug and attach the following listing.

U_ImiWMsbuNmW-5UQbm-jf0LuUw -> 2 beans:
- CLASS bean [types=[org.jboss.arquillian.testng.Arquillian, org.testng.ITestNGListener, org.testng.IHookable, org.eclipse.microprofile.fault.tolerance.tck.config.FallbackSkipOnConfigTest, java.lang.Object], qualifiers=[@Default, @Any], target=org.eclipse.microprofile.fault.tolerance.tck.config.FallbackSkipOnConfigTest]
- CLASS bean [types=[org.jboss.arquillian.testng.Arquillian, org.testng.ITestNGListener, org.testng.IHookable, org.eclipse.microprofile.fault.tolerance.tck.config.FallbackSkipOnConfigTest, java.lang.Object], qualifiers=[@Default, @Any], target=org.eclipse.microprofile.fault.tolerance.tck.config.FallbackSkipOnConfigTest]
================================================================================

I'll investigate tomorrow what's going on, but I guess the issue is in the Quarkus Arquillian adapter.

[Ladicek]

After considerable deliberation and discussion with @mkouba and @manovotn, I added a piece of code to bean discovery that prevents discovering the same bean class twice. The ultimate problem is that Jandex's CompositeIndex doesn't define what happens when the composition contains duplicates. In practice, most methods don't bother and just return duplicates whenever they exist. A stacked index would not have this problem, but I didn't prioritize it yet. (Perhaps I should.)

[quarkus-bot]

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

[psini]

I compiled the main and tested it. It works flawless . Is there any chance that will be back ported to 3.6.x ?

[manovotn]

I compiled the main and tested it. It works flawless . Is there any chance that will be back ported to 3.6.x ?

That might be a question for @gsmet