Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and edits to Protect a web service by using bearer token authentication tutorial #37616

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

sheilamjones
Copy link
Contributor

This PR contains minor doc edits, Vale fixes, and final publishing checks to the Protect a web service by using bearer token authentication tutorial guide.

Reference: QDOCS-538

@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Dec 8, 2023
Copy link

quarkus-bot bot commented Dec 8, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@sheilamjones sheilamjones requested a review from rolfedh December 8, 2023 13:23
@sheilamjones sheilamjones changed the title [Docs]: Review and edits to Protect a web service by using bearer token authentication tutorial Docs: Review and edits to Protect a web service by using bearer token authentication tutorial Dec 8, 2023
@sheilamjones sheilamjones changed the title Docs: Review and edits to Protect a web service by using bearer token authentication tutorial Review and edits to Protect a web service by using bearer token authentication tutorial Dec 8, 2023
Copy link

github-actions bot commented Dec 8, 2023

🙈 The PR is closed and the preview is expired.

@MichalMaler
Copy link
Contributor

MichalMaler commented Dec 8, 2023

Just a few little suggestions:

@sheilamjones Line 37 - Switch to active voice:

A Keycloak server issues the bearer token and represents the subject for which the token was issued.

Line 40:

Users with valid tokens can access the /api/users/me endpoint.

Line 289:

You can compile this same demo as-is into native mode without any modifications.

@sheilamjones
Copy link
Contributor Author

Hi @sberyozkin, Hi @MichalMaler,

Many thanks for your reviews of this guide. If all looks good from your perspective, I would appreciate your approvals and then this one is ready to merge.
Kind regards,
Sheila

@sheilamjones
Copy link
Contributor Author

Hi @sberyozkin,
If you get a moment, this PR is ready to merge.
Many thanks,
Sheila

@sheilamjones sheilamjones force-pushed the QDOCS-538-FINALCHECKS branch from 9179cfc to 6334763 Compare January 5, 2024 12:44
@sheilamjones
Copy link
Contributor Author

@sberyozkin, this PR is ready to merge when you get a moment. Many thanks.

@sheilamjones sheilamjones removed the request for review from rolfedh January 8, 2024 13:20
@sheilamjones sheilamjones marked this pull request as draft January 8, 2024 13:20
@sheilamjones
Copy link
Contributor Author

Update: setting back to Draft pending final SME approval.

@sberyozkin
Copy link
Member

@sheilamjones Can you please check if this PR resolves #38172 ?

@sheilamjones
Copy link
Contributor Author

Hi @sberyozkin,
Rolfe confirmed that the issue outlined in #38172 does NOT occur on Main. It is only occurring on version 3.6. Therefore, we propose to cherrypick and make the fix directly in the 3.6 branch. Therefore, this PR does not fix that issue.
Kind regards,
Sheila

@sheilamjones sheilamjones marked this pull request as ready for review January 15, 2024 18:38
@sheilamjones sheilamjones force-pushed the QDOCS-538-FINALCHECKS branch from 6334763 to f92ed4b Compare January 16, 2024 15:24
@sheilamjones
Copy link
Contributor Author

Thanks @sberyozkin. I made those final corrections. This is ready for merging if all looks okay to you. Many thanks for your time and detailed reviews with these topics. :)

Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sheila

@sberyozkin sberyozkin merged commit 09f15bc into quarkusio:main Jan 16, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docstyle issues related for manual docstyle review area/documentation
Projects
Development

Successfully merging this pull request may close these issues.

3 participants