-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review and edits to Protect a web service by using bearer token authentication tutorial #37616
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
🙈 The PR is closed and the preview is expired. |
Just a few little suggestions: @sheilamjones Line 37 - Switch to active voice: A Keycloak server issues the bearer token and represents the subject for which the token was issued. Line 40: Users with valid tokens can access the Line 289: You can compile this same demo as-is into native mode without any modifications. |
docs/src/main/asciidoc/security-oidc-bearer-token-authentication-tutorial.adoc
Outdated
Show resolved
Hide resolved
8f64f13
to
409d1c9
Compare
docs/src/main/asciidoc/security-oidc-bearer-token-authentication-tutorial.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-bearer-token-authentication-tutorial.adoc
Outdated
Show resolved
Hide resolved
409d1c9
to
9179cfc
Compare
Hi @sberyozkin, Hi @MichalMaler, Many thanks for your reviews of this guide. If all looks good from your perspective, I would appreciate your approvals and then this one is ready to merge. |
Hi @sberyozkin, |
9179cfc
to
6334763
Compare
@sberyozkin, this PR is ready to merge when you get a moment. Many thanks. |
Update: setting back to Draft pending final SME approval. |
@sheilamjones Can you please check if this PR resolves #38172 ? |
Hi @sberyozkin, |
docs/src/main/asciidoc/security-oidc-bearer-token-authentication-tutorial.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-oidc-bearer-token-authentication-tutorial.adoc
Outdated
Show resolved
Hide resolved
6334763
to
f92ed4b
Compare
Thanks @sberyozkin. I made those final corrections. This is ready for merging if all looks okay to you. Many thanks for your time and detailed reviews with these topics. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Sheila
This PR contains minor doc edits, Vale fixes, and final publishing checks to the Protect a web service by using bearer token authentication tutorial guide.
Reference: QDOCS-538