-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove @Traceless
annotation
#44724
base: main
Are you sure you want to change the base?
Remove @Traceless
annotation
#44724
Conversation
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
/cc @brunobat (opentelemetry), @radcortez (opentelemetry) |
For context, #43885 introduced the annotation (targetting 3.18) and this PR removes it, so no API breaking changes would be introduced if this PR is merged before 3.18 is released |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This comment has been minimized.
This comment has been minimized.
🎊 PR Preview e77760f has been successfully built and deployed to https://quarkus-pr-main-44724-preview.surge.sh/version/main/guides/
|
This comment has been minimized.
This comment has been minimized.
this one is related, I will take a look |
Test failures seem related? 🤔 |
I think yes... |
55f61e2
to
77f783f
Compare
Status for workflow
|
After this discussion on #43885 pull request, we decided to remove the annotation and to work only with the
quarkus.otel.traces.suppress-application-uris
property.I created another issue for tracking the
@Traceless
annotation. #44733