Polish quarto_create_project() #206
Conversation
| #' @param no_prompt Do not prompt to approve the creation of the new project | ||
| #' folder. |
There was a problem hiding this comment.
If the docs for no_prompt are inherited from quarto_add_extension() they don't really make sense here.
(In quarto_add_extension(), no_prompt means "Do not prompt to confirm approval to download external extension.")
| @@ -32,14 +40,14 @@ quarto_create_project <- function(name, type = "default", dir = ".", no_prompt = | |||
| "This will create a new Quarto {.emph {type}} project as a folder named {.strong {name}} in {.path {xfun::normalize_path(dir)}}." | |||
| )) | |||
| prompt_value <- tolower(readline(sprintf("Do you want to proceed (Y/n)? "))) | |||
| if (!prompt_value %in% "y") { | |||
| if (!prompt_value %in% c("", "y")) { | |||
There was a problem hiding this comment.
When I see (Y/n), I think it means that the default (just hitting "enter") is "Y" for "yes". I'm pretty certain that's how it behaves in other R packages that present such a choice. As it stands, if you just hit "enter", you get an error.
Best reference I can find for this: https://askubuntu.com/a/322601
| cli::cli_abort("Operation aborted.") | ||
| } | ||
| } | ||
|
|
||
| quarto_bin <- find_quarto() | ||
|
|
||
| args <- c("project", type, name, "--no-prompt", "--no-open", if (is_quiet(quiet)) cli_arg_quiet(), quarto_args = NULL) | ||
| args <- c("project", type, name, name, "--no-prompt", "--no-open", if (is_quiet(quiet)) cli_arg_quiet(), quarto_args = NULL) |
There was a problem hiding this comment.
Without this, I always get a warning, coming from the quarto cli, with no way to suppress it.
> quarto_create_project("my-first-quarto-project", dir = "~/tmp")
This will create a new Quarto default project as a folder named my-first-quarto-project in [/Users/jenny/tmp](vscode-file://vscode-app/Applications/Positron.app/Contents/Resources/app/out/vs/code/electron-sandbox/workbench/workbench.html#).
Do you want to proceed (Y/n)?
WARN: No 'title' for project provided in `quarto create project`. Using 'my-first-quarto-project' as default.
Creating project at /Users/jenny/tmp/my-first-quarto-project:
- Created _quarto.yml
- Created my-first-quarto-project.qmd
| # TODO: Fix the test once issue solve upstream | ||
| # - https://github.com/quarto-dev/quarto-cli/issues/8809 | ||
| # - https://github.com/quarto-dev/quarto-r/issues/153 | ||
| skip_if_quarto("1.5") |
There was a problem hiding this comment.
With my change re: name, these tests pass for me with Quarto 1.5, so I think they can be unskipped?
Some tweaks inspired by playing with
quarto_create_project()while looking at r-lib/usethis#1891Potentially addresses #153