Accessiblity #12
Merged
Accessiblity #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Let's not do the license change on this one, because if we do that, we want to synchronize that change along all extensions in |
This reverts commit 9a55673.
|
(I somehow was missing some notifications on this repo. Sorry about the delay. This looks good.) |
|
I was hoping for someone to confirm screen reader was working before merging, thus draft, although the changes can not hurt anyway. I tried the MacOS screen reader on different syntax, but it does not seem to work or I am mistaken about how it's suppose to work, so I stayed to the current one in that branch based on several accessibility recommendations. |
|
Ok, thanks for the added context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does:
aria-labelattribute.