Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup SCM.md #652

Closed
wants to merge 1 commit into from
Closed

Cleanup SCM.md #652

wants to merge 1 commit into from

Conversation

lubkoll
Copy link
Contributor

@lubkoll lubkoll commented Jul 15, 2024

Probably the release process should be updated. Plz check.

I am happy to add stuff (back) if needed.

Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the current branching rules for feature and fix segregation are well implemented and should remain unchanged. However, I propose that we introduce a more granular approach to release tagging by segregating them based on chain and contracts relating to a project. For instance, we could use tags such as v1.0.0-chain and v1.0.2-cl, where cl encompasses all contracts related to the CL range middleware, dexrouter, etc. Moving forward, as we develop additional products like LSA, each should have its own dedicated release tag for the associated contracts. This approach will enhance clarity in releases and versioning imo

@lubkoll
Copy link
Contributor Author

lubkoll commented Jul 18, 2024

I believe the current branching rules for feature and fix segregation are well implemented and should remain unchanged. However, I propose that we introduce a more granular approach to release tagging by segregating them based on chain and contracts relating to a project. For instance, we could use tags such as v1.0.0-chain and v1.0.2-cl, where cl encompasses all contracts related to the CL range middleware, dexrouter, etc. Moving forward, as we develop additional products like LSA, each should have its own dedicated release tag for the associated contracts. This approach will enhance clarity in releases and versioning imo

Are you talking about git tags? If so, yes, we can use them (though updating a tag on every minor version change is overkill imo -- except if we automate that). How do you currently mark the release state in git?

@lubkoll lubkoll requested a review from ajansari95 July 19, 2024 08:57
@lubkoll lubkoll closed this Jul 19, 2024
@lubkoll lubkoll deleted the feat/scm branch August 21, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants