Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate position creation from swap #753

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Separate position creation from swap #753

merged 2 commits into from
Aug 9, 2024

Conversation

lubkoll
Copy link
Contributor

@lubkoll lubkoll commented Aug 8, 2024

No description provided.

0xLaurenzo
0xLaurenzo requested changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@0xLaurenzo 0xLaurenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm, but we should remove SWAP_DEPOSIT_MERGE_STATE when we're done using it, last remove was deleted as part of the refactor. Also I think this removes our ability to just open a position. But that's probably for a different PR

smart-contracts/osmosis/contracts/cl-vault/src/vault/range.rs Show resolved Hide resolved
@lubkoll lubkoll requested a review from 0xLaurenzo August 9, 2024 10:02
@lubkoll
Copy link
Contributor Author

lubkoll commented Aug 9, 2024

generally lgtm, but we should remove SWAP_DEPOSIT_MERGE_STATE when we're done using it, last remove was deleted as part of the refactor. Also I think this removes our ability to just open a position. But that's probably for a different PR

Shouldn't have changed anything in the logic, just a refactor to separate concerns

0xLaurenzo
0xLaurenzo approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@0xLaurenzo 0xLaurenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lubkoll lubkoll merged commit 83f4a6e into main Aug 9, 2024
2 checks passed
@lubkoll lubkoll deleted the feat/cl-vault branch August 9, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xLaurenzo 0xLaurenzo 0xLaurenzo approved these changes

@arhamchordia arhamchordia Awaiting requested review from arhamchordia

@ajansari95 ajansari95 Awaiting requested review from ajansari95

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lubkoll @0xLaurenzo