Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CL: Swap Non Vault Funds (#782) #802

Merged
merged 15 commits into from
Aug 23, 2024
Merged

CL: Swap Non Vault Funds (#782) #802

merged 15 commits into from
Aug 23, 2024

Conversation

magiodev
Copy link
Contributor

@magiodev magiodev commented Aug 21, 2024

No description provided.

## 1. Overview

<!-- What are you changing, removing, or adding in this review? -->

## 2. Implementation details

<!-- Describe the implementation (highlights only) as well as design
rationale. -->

## 3. How to test/use

<!-- How can people test/use this? -->

## 4. Checklist

<!-- Checklist for PR author(s). -->

- [ ] Does the Readme need to be updated?

## 5. Limitations (optional)

<!-- Describe any limitation of the capabilities listed in the Overview
section. -->

## 6. Future Work (optional)

<!-- Describe follow up work, if any. -->

---------

Co-authored-by: ajansari95 <[email protected]>
@magiodev magiodev marked this pull request as ready for review August 21, 2024 12:36
@magiodev magiodev requested review from lubkoll and 0xLaurenzo August 21, 2024 13:23
lubkoll
lubkoll previously approved these changes Aug 21, 2024
0xLaurenzo
0xLaurenzo previously approved these changes Aug 22, 2024
Copy link
Contributor

@0xLaurenzo 0xLaurenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@magiodev magiodev dismissed stale reviews from 0xLaurenzo and lubkoll via f5147a9 August 23, 2024 07:21
@magiodev magiodev requested review from lubkoll and 0xLaurenzo August 23, 2024 08:10
@magiodev magiodev merged commit d4ac47a into main Aug 23, 2024
2 checks passed
@magiodev magiodev deleted the feat/swap_non_vault_funds branch August 23, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants