Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dex-router in test-tube tests #822

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

lubkoll
Copy link
Contributor

@lubkoll lubkoll commented Aug 26, 2024

This is part of the dex-router removal. To reduce the scope of that, I changed some of the test-tube tests to actually use the dex-router.

@lubkoll lubkoll force-pushed the feat/use-dex-router-in-test-tube branch from 2063bc8 to 877e26e Compare August 26, 2024 13:29
Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm , but any motivation behind changing the hardcoded test cases values (which would have been avoided earlier IMO ), is it due to any logical changes that we made earlier?

@lubkoll
Copy link
Contributor Author

lubkoll commented Aug 26, 2024

lgtm , but any motivation behind changing the hardcoded test cases values (which would have been avoided earlier IMO ), is it due to any logical changes that we made earlier?

Yes, absolutely. The dex-router was never used. I didn't want to change to much of the setup just to get to the same values as before.

@lubkoll lubkoll merged commit 2806902 into main Aug 26, 2024
3 checks passed
@lubkoll lubkoll deleted the feat/use-dex-router-in-test-tube branch August 26, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants