Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove writing to storage from mock_deps_with_querier and introduce s… #828

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

lubkoll
Copy link
Contributor

@lubkoll lubkoll commented Aug 27, 2024

No description provided.

ajansari95
ajansari95 previously approved these changes Aug 27, 2024
Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from feat/quasar-querier to main August 27, 2024 10:07
@lubkoll lubkoll dismissed ajansari95’s stale review August 27, 2024 10:07

The base branch was changed.

@lubkoll lubkoll force-pushed the feat/quasar-querier-2 branch from 74f4805 to 3b62b0e Compare August 27, 2024 10:07
@lubkoll lubkoll requested a review from ajansari95 August 27, 2024 10:10
Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lubkoll lubkoll merged commit 3a45b49 into main Aug 27, 2024
3 checks passed
@lubkoll lubkoll deleted the feat/quasar-querier-2 branch August 27, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants