Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncm-ssh: add ssh/sshd option GSSAPIKexAlgorithms to schema #1714

Merged
merged 1 commit into from
Sep 13, 2024
Merged

ncm-ssh: add ssh/sshd option GSSAPIKexAlgorithms to schema #1714

merged 1 commit into from
Sep 13, 2024

Conversation

ulrich1919
Copy link
Contributor

@ulrich1919 ulrich1919 commented Sep 12, 2024 •
edited by jrha
Loading

Fixes #1713

@ulrich1919 ulrich1919 mentioned this pull request Sep 12, 2024
Open
@jrha jrha changed the title Fixes #1713: ncm-ssh add ssh/sshd option GSSAPIKexAlgorithms to schem… ncm-ssh: add ssh/sshd option GSSAPIKexAlgorithms to schema Sep 12, 2024
@ulrich1919 ulrich1919 force-pushed the ssh_add_gssapikexalgorithms branch from 6e48839 to ebd631f Compare September 12, 2024 14:54
@jrha jrha added this to the 24.10 milestone Sep 13, 2024
@ulrich1919 ulrich1919 force-pushed the ssh_add_gssapikexalgorithms branch from ebd631f to 2b407aa Compare September 13, 2024 10:49
@ulrich1919
Copy link
Contributor Author

oh, btw choice() is a single choice right?
we need, multiple algorithms to be added. So choice() is not suitable here.

@jrha
Copy link
Member

jrha commented Sep 13, 2024 •
edited
Loading

It should be a list of items from choice() though, so you can still select multiple.

@ulrich1919 ulrich1919 force-pushed the ssh_add_gssapikexalgorithms branch 2 times, most recently from e34c09f to a650b16 Compare September 13, 2024 11:16
@ulrich1919 ulrich1919 force-pushed the ssh_add_gssapikexalgorithms branch from a650b16 to 683124f Compare September 13, 2024 11:27
jrha
jrha previously approved these changes Sep 13, 2024
View reviewed changes
@jrha jrha force-pushed the ssh_add_gssapikexalgorithms branch from 683124f to 646b4c1 Compare September 13, 2024 11:41
@jrha jrha merged commit 4057c4b into quattor:master Sep 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrha jrha jrha left review comments

Assignees
No one assigned
Labels
None yet
Milestone
24.10
Development

Successfully merging this pull request may close these issues.

ncm-ssh: add GSSAPIKexAlgorithms to PAN schema.
2 participants
@ulrich1919 @jrha