Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build packages for client and yum repositories #64

Merged
merged 7 commits into from
May 22, 2015

Conversation

jrha
Copy link
Member

@jrha jrha commented Nov 11, 2014

As discussed at Madrid workshop.

Fixes #16.
Fixes #17.

As discussed at Madrid workshop.

Fixes quattor#16.
Fixes quattor#17.
@jrha jrha added this to the 14.12 milestone Nov 11, 2014

[quattor-externals]
name=Quattor Externals
baseurl=http://yum.quattor.org/externals
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not ok. we really need a repo with a $releasever , and maybe a second externals repo that is truly cross-OS like the quattor one.
same for aquilon repo imho (since it's python, i'm assuming the rpms have the python version in the packge path)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we postponed solving these issues in 14.12, we should be able to rediscuss this now that we have a PR. I agree with @stdweird that we need to address the externals repo structure. I don't know what is referred to the "Quattor one" but if it is the one on quattorsrv.lal.in2p3.fr, I'd like to see it stopped in favor of one hosted at yum.quattor.org (see #62). This was only a temporary solution....

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jouvin sorry again for being not clear enough. with the quattor one i meant the quattor repo specified above (ie the one with the released components)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like:

/14.6.0/
/14.8.0/
/14.10.0/
/aquilon/el6/
/aquilon/el7/
/externals/el5/
/externals/el6/
/externals/el7/

Or the other way around?

/el5/externals/
/el6/aquilon
/el6/externals/
/el7/aquilon/
/el7/externals/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any comments?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, see #62

@jrha
Copy link
Member Author

jrha commented Nov 11, 2014

the one on quattorsrv.lal.in2p3.fr

I wasn't aware of this one...

@jouvin
Copy link
Contributor

jouvin commented Nov 11, 2014

http://quattorsrv.lal.in2p3.fr/packages/quattor/externals/... As said this was a temporary solution to be able to deliver obsolete RPMs still required by some components. I'll be happy to close it down after merging with an official one (see #62).

@jrha jrha modified the milestones: 15.2, 14.12 Jan 9, 2015
jrha added 2 commits April 27, 2015 15:18
Using naming consistent with template-library-standard.
@jrha
Copy link
Member Author

jrha commented Apr 27, 2015

Updated, please review 😅

<parent>
<groupId>org.quattor.maven</groupId>
<artifactId>build-profile</artifactId>
<version>1.32</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very old! Please update to last version...

@jouvin
Copy link
Contributor

jouvin commented May 5, 2015

With the exception of the comments above, LGTM.

@jrha
Copy link
Member Author

jrha commented May 11, 2015

I believe this is ready for merging, I would like to test the modifications I need to make to the release scripts when I build RC2, so it would be good to have this in before then (tomorrow morning).

<defaultDirmode>755</defaultDirmode>
<mappings>
<mapping>
<directory>/etc/quattor/</directory>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this used for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See src/quattor-client/src/README

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i did, but if that is the only file, it should go in /usr/share/quattor, not /etc imho
afaik, /etc/quattor is not used by any quattor tools (but maybe it should 😄 )

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shrugs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it should be /etc/quattor-release with a version number in it, I don't know.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Looks as the most useful thing to do. Will be consistent with /etc/redhat-release. As soon as it is done, I'll be happy to merge it...

We should figure out a better way to fix this.
@jrha jrha force-pushed the utility-packages branch from f7ea4c1 to be9a43e Compare May 12, 2015 10:00
More useful than a stubby README.
@jrha
Copy link
Member Author

jrha commented May 20, 2015

@jouvin, done and tested!

@jrha
Copy link
Member Author

jrha commented May 21, 2015

Will build RC4 (#96) when this is merged.

jrha added a commit that referenced this pull request May 22, 2015
Build packages for client and yum repositories
@jrha jrha merged commit c0999aa into quattor:master May 22, 2015
@jrha jrha deleted the utility-packages branch May 22, 2015 15:38
@jrha
Copy link
Member Author

jrha commented May 22, 2015

I hate having to merge my own stuff.

@jouvin
Copy link
Contributor

jouvin commented May 22, 2015

Sorry missing it, I would happily have done it and in fact I was waiting for your green light to do it but missed your comment...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

quattor-repo rpm quattor-client rpm
3 participants