specify required permissions on quay configuration files (PROJQUAY-6517) #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any thoughts @HammerMeetNail or @jonathankingfc ? Sorry to tag y'all directly, but with no contributing.md I'm not sure if I'm missing any steps, and would love to get either this merged, or a better path forward for ourselves & others affected by this issue. (#136) |
HammerMeetNail
added
the
ok-to-test
|
@BadgerOps Thanks for the PR, I just triggered CI. When you get a moment, can you rebase the branch? |
HammerMeetNail
force-pushed
the
feat/umask_fixes
branch
from
914f96b to
552ddbe
Compare
|
Actually, ignore that request, I was able to do it without any conflicts. |
HammerMeetNail
added
ok-to-test
|
Thanks for jumping on this @HammerMeetNail ! Happy to help the next person who's working in a fun environment 🤣 |
|
Hey, yeah, we talked about this today. I believe @harishsurf will be picking this up and reviewing. |
harishsurf
force-pushed
the
feat/umask_fixes
branch
from
552ddbe to
709683e
Compare
harishsurf
changed the title
|
/retest |
harishsurf
added
ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #136 with a hardened RHEL 8 instance with global umask of
0077the mirror-registry fails to install, due to the quay pod not being able to access the{{ quay_root }}/quay-configdirectory.This PR adds explicit mode for the directory and
config.yamlto allow a successful offline quay install with mirror-registry on a hardened environment.