-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: create secrets during upgrades (PROJQUAY-7001) #150
Conversation
7e45a4d
to
2d794a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
- name: Create Postgres Password Secret | ||
containers.podman.podman_secret: | ||
state: present | ||
name: pgdb_pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: do we want to replace it with {{ pgdb_password }}
defined in secret-vars.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would probably break existing users postgres DB's, right? If they got swapped from password
to an autogenerated password?
I'm not sure how redis handles that change, guessing if its ephemeral it won't cause an issue.
Hey @harishsurf @dmage sorry for this regression - I'm just wrapping up some local testing for a similar PR that generates facts :
Then creates the podman secrets with those - the reason I was thinking of going this route is to protect backwards compatibility. Of course, if the better option is to reset the passwords to what is autogenerated in Edit: Specifically the reason I was considering this route was in case other users had already manually changed the secrets in the config.yaml, and don't want to break their existing installs. |
I just submitted #151 with another way - let me know if y'all would prefer to do it another way and I'll close mine! |
Replaced by #151. |
No description provided.