db: Replace Postgres database with an in-app Sqlite db for Quay during fresh install of OMR #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: harishsurf <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
harishsurf
added
the
ok-to-test
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
dmage
reviewed
May 16, 2024
| - name: Create Sqlite Storage named volume | ||
| containers.podman.podman_volume: | ||
| state: present | ||
| name: sqlite-storage |
There was a problem hiding this comment.
It should use the name that is provided by the user.
.env
Outdated
| @@ -1,7 +1,6 @@ | |||
| EE_IMAGE=quay.io/quay/mirror-registry-ee:latest | |||
| EE_BASE_IMAGE=registry.redhat.io/ansible-automation-platform-22/ee-minimal-rhel8:1.0.0-249 | |||
| EE_BUILDER_IMAGE=registry.redhat.io/ansible-automation-platform-22/ansible-builder-rhel8:1.1.0-103 | |||
| POSTGRES_IMAGE=registry.redhat.io/rhel8/postgresql-10:1-203.1669834630 | |||
| QUAY_IMAGE=registry.redhat.io/quay/quay-rhel8:v3.8.15 | |||
| QUAY_IMAGE=quay.io/omr-sqlite/omrrepo:workingsqlite | |||
There was a problem hiding this comment.
It should be a Quay image that we maintain. Ideally from redhat.redhat.io, but a nightly build from quay.io/projectquay/quay would work too.
dmage
added
ok-to-test
harishsurf
added
ok-to-test
|
|
||
| - name: Debug systemctl status output | ||
| debug: | ||
| var: systemctl_status.stdout_lines |
There was a problem hiding this comment.
Can you make sure it exits at the end of this rescue block? Right now it will continue the rest of the tasks since we are handling the error
There was a problem hiding this comment.
added a fail task:
- name: Fail the playbook due to Quay not becoming alive
fail:
msg: "Quay did not become alive. Check debug logs above for details."
556ec57 to
112fbc1
Compare
harishsurf
added
ok-to-test
harishsurf
force-pushed
the
fresh-install
branch
from
112fbc1 to
f8edb22
Compare
harishsurf
added
ok-to-test
without this, multiple workers tend to write simultaneously causing concurrent write issues
harishsurf
force-pushed
the
fresh-install
branch
from
f8edb22 to
5927d2a
Compare
When podman runs containers in rootless mode, it remaps the container's UIDs to the host UIDs assigned to the user. For example, the container's UID 1001 is no longer 1001 on the host; it will be remapped to something like 101000. Therefore, we need to use podman unshare to assign the correct owner UID to the directory.
harishsurf
added
ok-to-test
dmage
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Sqlite database migration work for OMR is split into two parts (each with its own PR):
This PR only deals with fresh Install - It changes the underlying database for Quay which currently runs as a separate Postgres container to a file based Sqlite database. The Sqlite database file is stored in a volume mounted to the Quay container.
Note:
./mirror-registry installflow