Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
return nil not error on ack_error receipt, else we just get the same …
Browse files Browse the repository at this point in the history
…acknowledgement repeatedly submitted indefinitely
Joe Bowman committed Dec 30, 2022
1 parent 9aa37bc commit db4777b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions x/interchainstaking/keeper/ibc_packet_handlers.go
Original file line number Diff line number Diff line change
@@ -51,7 +51,8 @@ func (k *Keeper) HandleAcknowledgement(ctx sdk.Context, packet channeltypes.Pack

k.Logger(ctx).Error("received an acknowledgement error", "error", err, "remote_err", ackErr, "data", acknowledgement)
defer telemetry.IncrCounter(1, types.ModuleName, "ica_acknowledgement_errors")
return errors.New("received an acknowledgement error; unable to process")
return nil
//return errors.New("received an acknowledgement error; unable to process") // this just causes the same errAck to be submitted repeatedly.
}
defer telemetry.IncrCounter(1, types.ModuleName, "ica_acknowledgement_success")
txMsgData := &sdk.TxMsgData{}
@@ -108,7 +109,6 @@ func (k *Keeper) HandleAcknowledgement(ctx sdk.Context, packet channeltypes.Pack
return err
}
k.Logger(ctx).Info("Shares tokenized", "response", response)
// check tokenizedShareTransfers (inc. rebalance and unbond)
if err := k.HandleTokenizedShares(ctx, src, response.Amount, packetData.Memo); err != nil {
return err
}

0 comments on commit db4777b

Please sign in to comment.