Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vercel build magic #1084

Merged
merged 2 commits into from
Jan 24, 2024
Merged

vercel build magic #1084

merged 2 commits into from
Jan 24, 2024

Conversation

joe-bowman
Copy link
Contributor

@joe-bowman joe-bowman commented Jan 24, 2024

1. Summary

Adds CI pipeline logic for vercel f/e builds

Summary by CodeRabbit

  • Chores
    • Improved the build process to ensure deterministic dependency resolution.
    • Implemented a new deployment workflow for production releases.
    • Updated .gitignore to exclude the .vercel directory from version control.

@joe-bowman joe-bowman requested a review from faddat as a code owner January 24, 2024 11:22
Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for transcendent-kelpie-6c389e canceled.

Name Link
🔨 Latest commit efadcac
🔍 Latest deploy log https://app.netlify.com/sites/transcendent-kelpie-6c389e/deploys/65b0f2f14469690008cd6121

Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quicksilver ❌ Failed (Inspect) Jan 24, 2024 11:27am

Copy link
Contributor

coderabbitai bot commented Jan 24, 2024

Warning

Rate Limit Exceeded

@joe-bowman has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 17 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between efadcac and 1f931c1.

Walkthrough

The project has introduced measures to ensure consistent dependency installations with --frozen-lockfile and expanded its CI/CD pipeline to include deployment to Vercel. The .gitignore file has been updated to exclude the .vercel directory, likely used for Vercel's deployment specifics.

Changes

File Path Change Summary
.github/workflows/.../buildweb.yaml Added --frozen-lockfile to bun install for deterministic builds
.github/workflows/.../deployweb.yaml Created a workflow for Vercel deployment on production tag push
.gitignore Ignored .vercel directory

🐇✨
To the code, we hop and tweak,
With frozen lockfiles, no more unique.
Through workflows, our web shall peak,
On Vercel's clouds, it finds its mystique. 🚀🌥️

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between e9baead and efadcac.
Files ignored due to path filters (1)
  • vercel.json is excluded by: !**/*.json
Files selected for processing (3)
  • .github/workflows/buildweb.yaml (1 hunks)
  • .github/workflows/deployweb.yaml (1 hunks)
  • .gitignore (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/buildweb.yaml
Additional comments: 5
.gitignore (1)
  • 75-75: The addition of .vercel to the .gitignore file is correct and follows best practices for excluding deployment-specific directories from version control.
.github/workflows/deployweb.yaml (4)
  • 1-22: The new deployweb.yaml workflow file is set up correctly to deploy production tags to Vercel. It includes environment variables, installation of the Vercel CLI, pulling environment information, building, and deploying the project artifacts.
  • 3-4: Ensure that VERCEL_ORG_ID and VERCEL_PROJECT_ID are appropriately secured as GitHub secrets and have limited access.
  • 5-8: The trigger for the deployment workflow is set to activate on tag pushes that match 'fe/v*'. Confirm that this pattern aligns with the project's tagging conventions for production releases.
  • 18-22: The VERCEL_TOKEN is used in multiple steps. Ensure that this token has the minimal required permissions for the operations it needs to perform and is stored securely as a GitHub secret.

.github/workflows/deployweb.yaml Outdated Show resolved Hide resolved
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@joe-bowman joe-bowman merged commit b646301 into main Jan 24, 2024
22 of 23 checks passed
@joe-bowman joe-bowman deleted the vercel-build branch January 24, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant