Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/v1.7.0-rc1 #1737

Merged
merged 6 commits into from
Nov 8, 2024
Merged

Release/v1.7.0-rc1 #1737

merged 6 commits into from
Nov 8, 2024

Conversation

joe-bowman
Copy link
Contributor

1. Summary

Fixes a number of small bugs:

  • ensure we register inclusion proof implementations
  • guard against panic in claimsmanager hook
  • handle local zone containing multiple hyphens
  • fix bug with share proof reconstruction if non-zero starting index
  • handle compatibility mode config in icq-relayer
  • properly handle tendermint tx proofs in icq-relayer (introduced in v1.1.0)

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 7, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

ajansari95
ajansari95 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ajansari95 ajansari95 merged commit 25357a7 into release/v1.7.x Nov 8, 2024
12 checks passed
@ajansari95 ajansari95 deleted the release/v1.7.0 branch November 8, 2024 10:29
joe-bowman added a commit that referenced this pull request Nov 14, 2024
@joe-bowman @ajansari95 @coderabbitai
Release/v1.7.x (#1733)
96439da 
* beta.0

* wip

* handle celestia inclusion proofs

* tidy versioning

* bump docker build deps

* docker build fixes

* bump all workflows to go1.23

* bump docker containers to go1.23 alpine3.20

* remove relayer Dockerfile

* Release/v1.7.0-rc1 (#1737)

* register inclusion proof implementations

* handle compat mode properly

* fix issue with proof reconstruction from non-zero index

* ensure we unmarshal the result for default tx types

* guard against panic in epoch hook for brand new zone

* fix bug in claims manager if local chain id has multiple hyphens

* update deposit tx tests to use new proof marshalling format

* update test to check value of found

* lint fix

* bump linter to v1.62.0

* fix lint (#1739)

* ignore typecast lints (#1740)

* feat: add periodic delegation balance poling icq (#1741)

* add periodic poling icq

* revert redundant callback

* add completion time field to unbonding record, and populate on acknowledgement; make RR logic ignore unbonding and escrowed tokens, add v1.7.0 upgrade handler (#1742)

* lint fix

* fix tests to reflect RR logic change

* Update icq-relayer/pkg/types/config.go

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update x/interchainstaking/keeper/ibc_packet_handlers.go

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* remove redundant import

* go 1.23.3

* Revert "Update x/interchainstaking/keeper/ibc_packet_handlers.go"

This reverts commit 4990cf4.

* Update utils/proofs/proofs.go

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update utils/proofs/proofs.go

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update utils/proofs/proofs.go

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Update utils/proofs/proofs.go

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* lint

---------

Co-authored-by: Joe Bowman <[email protected]>
Co-authored-by: Ajaz Ahmed <[email protected]>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajansari95 ajansari95 ajansari95 approved these changes

@faddat faddat Awaiting requested review from faddat faddat is a code owner

Assignees
No one assigned
Labels
x/claimsmanager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joe-bowman @ajansari95