Add pod lifecycle #104
Merged
Add pod lifecycle #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for unblocking the CI @guilload. I can see it failed lint as I didn't bump the version of this chart. If you are ok with this PR and it gets approved, what value you recommend to be changed? Let me know if there's something I can do. Thank you. |
guilload
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
LGTM. Thanks for linking the blog post. See also this ALB controller issue. Can you please bump the chart's version (patch) so we can merge this PR?
Yep, this is exactly the original issue. I've bumped the Chart version to 0.7.2. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced pod lifecycle. When using the AWS Load Balancer Controller, deployments of pods trigger 5xx gateway errors when doing config changes, since the target group registration/deregistration of pods is out of sync with kubernetes service network orchestration (when an indexer pod gets terminated with a SIGTERM, it's done immediately, not giving enough time to drain connections from the ALB's target group, triggering 5xx errors to the client). Introducing a sleep time on indexers can help avoid this during pod termination (as a pre-stop action).
Related: https://medium.com/@imprintpayments/mastering-the-challenges-of-using-alb-ingress-in-kubernetes-8c28a8f826c5