Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make log limits configurable #115

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Make log limits configurable #115

merged 1 commit into from
Apr 9, 2024

Conversation

ddelemeny
Copy link
Contributor

@ddelemeny ddelemeny commented Apr 9, 2024 •
edited
Loading

  • Add a redux store to hold the defaults state
  • Use a HOC to provide the store to the queryEditor
  • Define overrides in ConfigEditor

Defaults overrides keys are flattened to use a deep set instead of a merge for store mutations.

Fixes #114

@ddelemeny ddelemeny requested a review from fmassot April 9, 2024 13:02
fmassot
fmassot approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@fmassot fmassot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on macOS.

@ddelemeny ddelemeny merged commit 1b06e17 into main Apr 9, 2024
2 checks passed
@ddelemeny ddelemeny deleted the ddelemeny/configurable-editor-defaults branch April 9, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassot fmassot fmassot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revert default search limit to 100 and make it configurable
2 participants
@ddelemeny @fmassot