Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional Lindera tokenizer support (was: Custom tokenizer support) #200
base: master
Are you sure you want to change the base?
Optional Lindera tokenizer support (was: Custom tokenizer support) #200
Changes from 2 commits
d9fc544
6e82b23
64dc8df
27e2f41
a94c3cc
7ea1d8f
051e790
3765098
0a3f53c
a985769
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It took a surprisingly long time to discover the correct way to spell how to get this value sent down to the build backend!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, even with the unified
pyproject.toml
approach, wiring Python builds is still a mess IMHO. Do you remember where in the Maturin documentation you would have expected this? Maybe an improvement is just a PR away?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maturin wasn't too bad, it is pretty easy to find "feature selection" and that shows up under the
build-wheels
section in the maturin docs. Much more difficult to find was how to propagate the feature parameter through the pip interface, as above.I had a quick look, I think this section is probably the best place to mention the
build-args
parameter: https://www.maturin.rs/index.html?highlight=pip%20install#python-packaging-basics