add support for counting non integer in aggregation #4178
trinity-1686aAnnotations
45 warnings
|
the following explicit lifetimes could be elided: 'a:
columnar/src/iterable.rs#L10
warning: the following explicit lifetimes could be elided: 'a
--> columnar/src/iterable.rs:10:6
|
10 | impl<'a, T: Copy> Iterable<T> for &'a [T] {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
10 - impl<'a, T: Copy> Iterable<T> for &'a [T] {
10 + impl<T: Copy> Iterable<T> for &[T] {
|
|
|
the following explicit lifetimes could be elided: 'a:
columnar/src/columnar/writer/serializer.rs#L83
warning: the following explicit lifetimes could be elided: 'a
--> columnar/src/columnar/writer/serializer.rs:83:6
|
83 | impl<'a, W: io::Write> io::Write for ColumnSerializer<'a, W> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
83 - impl<'a, W: io::Write> io::Write for ColumnSerializer<'a, W> {
83 + impl<W: io::Write> io::Write for ColumnSerializer<'_, W> {
|
|
|
the following explicit lifetimes could be elided: 'a:
columnar/src/columnar/writer/serializer.rs#L70
warning: the following explicit lifetimes could be elided: 'a
--> columnar/src/columnar/writer/serializer.rs:70:6
|
70 | impl<'a, W: io::Write> ColumnSerializer<'a, W> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
70 - impl<'a, W: io::Write> ColumnSerializer<'a, W> {
70 + impl<W: io::Write> ColumnSerializer<'_, W> {
|
|
|
the following explicit lifetimes could be elided: 'a:
columnar/src/columnar/merge/term_merger.rs#L19
warning: the following explicit lifetimes could be elided: 'a
--> columnar/src/columnar/merge/term_merger.rs:19:6
|
19 | impl<'a> Eq for HeapItem<'a> {}
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
19 - impl<'a> Eq for HeapItem<'a> {}
19 + impl Eq for HeapItem<'_> {}
|
|
|
the following explicit lifetimes could be elided: 'a:
columnar/src/columnar/merge/term_merger.rs#L13
warning: the following explicit lifetimes could be elided: 'a
--> columnar/src/columnar/merge/term_merger.rs:13:6
|
13 | impl<'a> PartialEq for HeapItem<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
13 - impl<'a> PartialEq for HeapItem<'a> {
13 + impl PartialEq for HeapItem<'_> {
|
|
|
the following explicit lifetimes could be elided: 'a:
columnar/src/columnar/merge/merge_dict_column.rs#L53
warning: the following explicit lifetimes could be elided: 'a
--> columnar/src/columnar/merge/merge_dict_column.rs:53:6
|
53 | impl<'a> RemappedTermOrdinalsValues<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
53 - impl<'a> RemappedTermOrdinalsValues<'a> {
53 + impl RemappedTermOrdinalsValues<'_> {
|
|
|
the following explicit lifetimes could be elided: 'a:
columnar/src/columnar/merge/merge_dict_column.rs#L42
warning: the following explicit lifetimes could be elided: 'a
--> columnar/src/columnar/merge/merge_dict_column.rs:42:6
|
42 | impl<'a> Iterable for RemappedTermOrdinalsValues<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
42 - impl<'a> Iterable for RemappedTermOrdinalsValues<'a> {
42 + impl Iterable for RemappedTermOrdinalsValues<'_> {
|
|
|
manually reimplementing `div_ceil`:
columnar/src/column_values/u64_based/blockwise_linear.rs#L42
warning: manually reimplementing `div_ceil`
--> columnar/src/column_values/u64_based/blockwise_linear.rs:42:5
|
42 | (num_vals + BLOCK_SIZE - 1) / BLOCK_SIZE
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `num_vals.div_ceil(BLOCK_SIZE)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil
|
|
the following explicit lifetimes could be elided: 'a:
columnar/src/column_values/merge.rs#L13
warning: the following explicit lifetimes could be elided: 'a
--> columnar/src/column_values/merge.rs:13:6
|
13 | impl<'a, T: Copy + PartialOrd + Debug + 'static> Iterable<T> for MergedColumnValues<'a, T> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
13 - impl<'a, T: Copy + PartialOrd + Debug + 'static> Iterable<T> for MergedColumnValues<'a, T> {
13 + impl<T: Copy + PartialOrd + Debug + 'static> Iterable<T> for MergedColumnValues<'_, T> {
|
|
|
the following explicit lifetimes could be elided: 'a:
columnar/src/column_index/serialize.rs#L34
warning: the following explicit lifetimes could be elided: 'a
--> columnar/src/column_index/serialize.rs:34:6
|
34 | impl<'a> SerializableColumnIndex<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
34 - impl<'a> SerializableColumnIndex<'a> {
34 + impl SerializableColumnIndex<'_> {
|
|
|
manually reimplementing `div_ceil`:
columnar/src/column_index/optional_index/mod.rs#L508
warning: manually reimplementing `div_ceil`
--> columnar/src/column_index/optional_index/mod.rs:508:9
|
508 | ((num_rows + ELEMENTS_PER_BLOCK - 1) / ELEMENTS_PER_BLOCK) as usize,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `num_rows.div_ceil(ELEMENTS_PER_BLOCK)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil
= note: `#[warn(clippy::manual_div_ceil)]` on by default
|
|
the following explicit lifetimes could be elided: 'a:
columnar/src/column_index/optional_index/mod.rs#L168
warning: the following explicit lifetimes could be elided: 'a
--> columnar/src/column_index/optional_index/mod.rs:168:6
|
168 | impl<'a> SelectCursor<RowId> for OptionalIndexSelectCursor<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
168 - impl<'a> SelectCursor<RowId> for OptionalIndexSelectCursor<'a> {
168 + impl SelectCursor<RowId> for OptionalIndexSelectCursor<'_> {
|
|
|
the following explicit lifetimes could be elided: 'a:
columnar/src/column_index/optional_index/mod.rs#L144
warning: the following explicit lifetimes could be elided: 'a
--> columnar/src/column_index/optional_index/mod.rs:144:6
|
144 | impl<'a> OptionalIndexSelectCursor<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
144 - impl<'a> OptionalIndexSelectCursor<'a> {
144 + impl OptionalIndexSelectCursor<'_> {
|
|
|
the following explicit lifetimes could be elided: 'a:
columnar/src/column_index/optional_index/mod.rs#L126
warning: the following explicit lifetimes could be elided: 'a
--> columnar/src/column_index/optional_index/mod.rs:126:6
|
126 | impl<'a> BlockSelectCursor<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
126 - impl<'a> BlockSelectCursor<'a> {
126 + impl BlockSelectCursor<'_> {
|
|
|
the following explicit lifetimes could be elided: 'a:
columnar/src/column_index/optional_index/mod.rs#L89
warning: the following explicit lifetimes could be elided: 'a
--> columnar/src/column_index/optional_index/mod.rs:89:6
|
89 | impl<'a> Iterable<u32> for &'a OptionalIndex {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
89 - impl<'a> Iterable<u32> for &'a OptionalIndex {
89 + impl Iterable<u32> for &OptionalIndex {
|
|
|
the following explicit lifetimes could be elided: 'a:
columnar/src/column_index/optional_index/set_block/sparse.rs#L72
warning: the following explicit lifetimes could be elided: 'a
--> columnar/src/column_index/optional_index/set_block/sparse.rs:72:6
|
72 | impl<'a> SparseBlock<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
72 - impl<'a> SparseBlock<'a> {
72 + impl SparseBlock<'_> {
|
|
|
the following explicit lifetimes could be elided: 'a:
columnar/src/column_index/optional_index/set_block/sparse.rs#L34
warning: the following explicit lifetimes could be elided: 'a
--> columnar/src/column_index/optional_index/set_block/sparse.rs:34:6
|
34 | impl<'a> Set<u16> for SparseBlock<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
34 - impl<'a> Set<u16> for SparseBlock<'a> {
34 + impl Set<u16> for SparseBlock<'_> {
|
|
|
the following explicit lifetimes could be elided: 'a:
columnar/src/column_index/optional_index/set_block/dense.rs#L178
warning: the following explicit lifetimes could be elided: 'a
--> columnar/src/column_index/optional_index/set_block/dense.rs:178:6
|
178 | impl<'a> DenseBlock<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
178 - impl<'a> DenseBlock<'a> {
178 + impl DenseBlock<'_> {
|
|
|
the following explicit lifetimes could be elided: 'a:
columnar/src/column_index/optional_index/set_block/dense.rs#L112
warning: the following explicit lifetimes could be elided: 'a
--> columnar/src/column_index/optional_index/set_block/dense.rs:112:6
|
112 | impl<'a> SelectCursor<u16> for DenseBlockSelectCursor<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
112 - impl<'a> SelectCursor<u16> for DenseBlockSelectCursor<'a> {
112 + impl SelectCursor<u16> for DenseBlockSelectCursor<'_> {
|
|
|
empty line after doc comment:
columnar/src/column_index/optional_index/set_block/dense.rs#L25
warning: empty line after doc comment
--> columnar/src/column_index/optional_index/set_block/dense.rs:25:1
|
25 | / /// block. Direct computation is not possible, but we can employ a linear or binary search.
26 | |
| |_
27 | const ELEMENTS_PER_MINI_BLOCK: u16 = 64;
| ---------------------------------- the comment documents this constant
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
= help: if the empty line is unintentional remove it
|
|
the following explicit lifetimes could be elided: 'a:
columnar/src/column_index/merge/stacked.rs#L126
warning: the following explicit lifetimes could be elided: 'a
--> columnar/src/column_index/merge/stacked.rs:126:6
|
126 | impl<'a> Iterable<u32> for StackedStartOffsets<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
126 - impl<'a> Iterable<u32> for StackedStartOffsets<'a> {
126 + impl Iterable<u32> for StackedStartOffsets<'_> {
|
|
|
the following explicit lifetimes could be elided: 'a:
columnar/src/column_index/merge/shuffled.rs#L130
warning: the following explicit lifetimes could be elided: 'a
--> columnar/src/column_index/merge/shuffled.rs:130:6
|
130 | impl<'a> Iterable<u32> for ShuffledMultivaluedIndex<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
130 - impl<'a> Iterable<u32> for ShuffledMultivaluedIndex<'a> {
130 + impl Iterable<u32> for ShuffledMultivaluedIndex<'_> {
|
|
|
the following explicit lifetimes could be elided: 'a:
columnar/src/column_index/merge/shuffled.rs#L61
warning: the following explicit lifetimes could be elided: 'a
--> columnar/src/column_index/merge/shuffled.rs:61:6
|
61 | impl<'a> Iterable<u32> for ShuffledIndex<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
61 - impl<'a> Iterable<u32> for ShuffledIndex<'a> {
61 + impl Iterable<u32> for ShuffledIndex<'_> {
|
|
|
the following explicit lifetimes could be elided: 'a:
sstable/src/streamer.rs#L181
warning: the following explicit lifetimes could be elided: 'a
--> sstable/src/streamer.rs:181:6
|
181 | impl<'a, TSSTable, A> Streamer<'a, TSSTable, A>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
181 - impl<'a, TSSTable, A> Streamer<'a, TSSTable, A>
181 + impl<TSSTable, A> Streamer<'_, TSSTable, A>
|
|
|
the following explicit lifetimes could be elided: 'a:
sstable/src/streamer.rs#L164
warning: the following explicit lifetimes could be elided: 'a
--> sstable/src/streamer.rs:164:6
|
164 | impl<'a, TSSTable> Streamer<'a, TSSTable, AlwaysMatch>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
164 - impl<'a, TSSTable> Streamer<'a, TSSTable, AlwaysMatch>
164 + impl<TSSTable> Streamer<'_, TSSTable, AlwaysMatch>
|
|
|
the following explicit lifetimes could be elided: 'a:
tokenizer-api/src/lib.rs#L93
warning: the following explicit lifetimes could be elided: 'a
--> tokenizer-api/src/lib.rs:93:6
|
93 | impl<'a> DerefMut for BoxTokenStream<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
93 - impl<'a> DerefMut for BoxTokenStream<'a> {
93 + impl DerefMut for BoxTokenStream<'_> {
|
|
|
the following explicit lifetimes could be elided: 'a:
tokenizer-api/src/lib.rs#L66
warning: the following explicit lifetimes could be elided: 'a
--> tokenizer-api/src/lib.rs:66:6
|
66 | impl<'a> TokenStream for BoxTokenStream<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
66 - impl<'a> TokenStream for BoxTokenStream<'a> {
66 + impl TokenStream for BoxTokenStream<'_> {
|
|
|
the following explicit lifetimes could be elided: 'a:
stacker/src/expull.rs#L77
warning: the following explicit lifetimes could be elided: 'a
--> stacker/src/expull.rs:77:6
|
77 | impl<'a> ExpUnrolledLinkedListWriter<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
77 - impl<'a> ExpUnrolledLinkedListWriter<'a> {
77 + impl ExpUnrolledLinkedListWriter<'_> {
|
|
|
the following explicit lifetimes could be elided: 'a:
common/src/writer.rs#L90
warning: the following explicit lifetimes could be elided: 'a
--> common/src/writer.rs:90:6
|
90 | impl<'a> TerminatingWrite for &'a mut Vec<u8> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
90 - impl<'a> TerminatingWrite for &'a mut Vec<u8> {
90 + impl TerminatingWrite for &mut Vec<u8> {
|
|
|
check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
test-all
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
test-all
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
test-all
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
test-all
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
test-quickwit
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
test-quickwit
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
test-quickwit
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
test-quickwit
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|