Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: switch between uncontrolled and controlled #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FezVrasta
Copy link
Contributor

PR checklist

  • I have followed the "Committing and publishing" guidelines;
  • I have added unit tests to cover my changes;
  • I updated the documentation and examples accordingly;

Changes description

This PR adds two tests that check the switch between controlled and uncontrolled states of the dropdown component.

The second test is not passing, we should fix this issue.

Affected packages

  • @quid/react-dropdown

@FezVrasta FezVrasta requested a review from gabrielmicko March 4, 2019 15:28
@FezVrasta FezVrasta force-pushed the test/multidropdown-controlled-uncontrolled-switch branch from 201097f to 4cff653 Compare March 4, 2019 15:35
@FezVrasta
Copy link
Contributor Author

@gabrielmicko to fix this you may use the new @quid/react-use-controlled-state Hook, it should simplify the logic a lot.

https://ui.quid.com/#react-use-controlled-state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant