Fallback to disk for loading test resources when bundle does not exist #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 15, 2019 00:28
This is kind of a hack, but a well known one, to be able to run the tests if you have regenerated SwiftyChrono.xcodeproj with SPM.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch extracts test resource loading logic to a method.
The new method will load the resource from the lib bundle. If the resource file is not contained in the bundle, it will attempt to load it directly from disk.
That change will allow the tests to pass in scenarios where the lib bundle does not contain the test resources (e.g. if you regenerate the project file using Swift Package Manager, see #13).