When tag value is set to null in AddTags, treat as removal (#35)

quixio · Feb 13, 2024 · 4e1dd40 · 4e1dd40
1 parent a689b55
commit 4e1dd40
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/src/QuixStreams.Streaming.UnitTests/Models/TimeseriesDataTimestampShould.cs b/src/QuixStreams.Streaming.UnitTests/Models/TimeseriesDataTimestampShould.cs
@@ -18,6 +18,11 @@ public void AddTags_NullAndEmptyTags_ShouldNotThrowException()
             tsdts.AddTag("test2", "val5");
             tsdts.AddTags(null);
             tsdts.AddTags(new Dictionary<string, string>());
+            tsdts.AddTag("test5", "willgetdeleted");
+            tsdts.AddTags(new Dictionary<string, string>()
+            {
+                {"test5", null}
+            });
 
             // Assert
             tsdts.Tags.Count.Should().Be(2);

diff --git a/src/QuixStreams.Streaming/Models/EventData.cs b/src/QuixStreams.Streaming/Models/EventData.cs
@@ -146,7 +146,8 @@ public EventData AddTags(IEnumerable<KeyValuePair<string, string>> tags)
 
             foreach (var tagPair in tags)
             {
-                this.AddTag(tagPair.Key, tagPair.Value);
+                if (string.IsNullOrEmpty(tagPair.Value)) this.RemoveTag(tagPair.Key);
+                else this.AddTag(tagPair.Key, tagPair.Value);
             }
 
             return this;

diff --git a/src/QuixStreams.Streaming/Models/TimeseriesDataTimestamp.cs b/src/QuixStreams.Streaming/Models/TimeseriesDataTimestamp.cs
@@ -207,7 +207,8 @@ public TimeseriesDataTimestamp AddTags(IEnumerable<KeyValuePair<string, string>>
 
             foreach (var tagPair in tags)
             {
-                this.AddTag(tagPair.Key, tagPair.Value);
+                if (string.IsNullOrEmpty(tagPair.Value)) this.RemoveTag(tagPair.Key);
+                else this.AddTag(tagPair.Key, tagPair.Value);
             }
 
             return this;