Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iterate through relations if paginated #15

Merged
merged 1 commit into from Jan 29, 2018
Merged

iterate through relations if paginated #15

merged 1 commit into from Jan 29, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jan 29, 2018

This PR allows returning link to relationship as an iterator. replace #10

see #6

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 85.816% when pulling 567cbed on ola-t:iterator_relation into d3353b7 on qvantel:master.

@ghost
Copy link
Author

ghost commented Jan 29, 2018

Would you think it possible to change this to be a new feature? I mean by adding for example a key word parameter to Session such as "return_link_relationship_as_iterator" and defaulting to False. Then add if-else to this LinkRelationship class accordingly. This would ensure backward compatibility. What do you think?

@ajjn does this work now for you?

@ajjn
Copy link
Contributor

ajjn commented Jan 29, 2018

Yeah, that's great! Thanks for your contributions!

@ajjn ajjn merged commit 11bf6fe into qvantel:master Jan 29, 2018
@ghost ghost deleted the iterator_relation branch January 29, 2018 11:26
@ghost
Copy link
Author

ghost commented Jan 29, 2018

When this patch could be released, roughtly?

@ghost
Copy link
Author

ghost commented Jan 29, 2018

I didnt expect merging that so quickly, would you consider better name for return_link_relationship_as_iterator like relationship_iterator ? (Sorry, should ask before)

@ghost ghost mentioned this pull request Jan 29, 2018
elebow added a commit to Cofense/triage-sdk-python that referenced this pull request Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants