Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This translates shell scripts to python, so migrations can be run on windows too.
I tested it locally. Some notes/comments/questions:
On the test DB, sigip views must be dropped manually (otherwise pre-all fails with
cannot drop view qwat_od.vw_export_pipe because other objects depend on it
). What is the status of these views ? Is it normal that pre-all does not drop them and post-all recreate them ?Before merging this, we should make CI work again, as otherwise it's too risky to do this type of work (see Continuous Integration CI : Unit test are no longer running on pull requests #348)
Also, before this is usable, another blocker must be fixed:
delta_1.4.0_003_create_fk_leak_type
fails withcolumn "fk_leak_type" does not exist
#353