Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #354

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Windows support #354

wants to merge 4 commits into from

Conversation

olivierdalang
Copy link
Collaborator

This translates shell scripts to python, so migrations can be run on windows too.

I tested it locally. Some notes/comments/questions:

@olivierdalang olivierdalang requested a review from 3nids April 27, 2022 13:50
@3nids
Copy link
Member

3nids commented Apr 27, 2022

On the test DB, sigip views must be dropped manually (otherwise pre-all fails with cannot drop view qwat_od.vw_export_pipe because other objects depend on it). What is the status of these views ? Is it normal that pre-all does not drop them and post-all recreate them ?

I think we should not have views in extra schemas in the test DB. They might need to be removed?

Before merging this, we should make CI work again, as otherwise it's too risky to do this type of work

Indeed. @ponceta is there any plan here?

Also, before this is usable, another blocker must be fixed: #353

@ponceta would you look to this one too?

@ponceta
Copy link
Member

ponceta commented Apr 28, 2022

To make things right I would propose as guidelines from experience:

  • export views must ALL be in an export schema (qwat_export) (like QGEP)
  • custom views must not reference export views (avoid locks as much as possible)
  • documentation and process should take into account a few custom views as examples -> rewrite some (not all) of the sigip views into custom views

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datamodel Datamodel related Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delta_1.4.0_003_create_fk_leak_type fails with column "fk_leak_type" does not exist
3 participants