Skip to content

Commit

Permalink
CRAN comments (#350)
Browse files Browse the repository at this point in the history
* CRAN comments

* Bump version to 1.3.2.9900

* Add rhub

* NEWS
  • Loading branch information
krlmlr authored Nov 18, 2024
1 parent a9cd9b2 commit 6c2a299
Show file tree
Hide file tree
Showing 4 changed files with 102 additions and 161 deletions.
95 changes: 95 additions & 0 deletions .github/workflows/rhub.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
# R-hub's generic GitHub Actions workflow file. It's canonical location is at
# https://github.com/r-hub/actions/blob/v1/workflows/rhub.yaml
# You can update this file to a newer version using the rhub2 package:
#
# rhub::rhub_setup()
#
# It is unlikely that you need to modify this file manually.

name: R-hub
run-name: "${{ github.event.inputs.id }}: ${{ github.event.inputs.name || format('Manually run by {0}', github.triggering_actor) }}"

on:
workflow_dispatch:
inputs:
config:
description: 'A comma separated list of R-hub platforms to use.'
type: string
default: 'linux,windows,macos'
name:
description: 'Run name. You can leave this empty now.'
type: string
id:
description: 'Unique ID. You can leave this empty now.'
type: string

jobs:

setup:
runs-on: ubuntu-latest
outputs:
containers: ${{ steps.rhub-setup.outputs.containers }}
platforms: ${{ steps.rhub-setup.outputs.platforms }}

steps:
# NO NEED TO CHECKOUT HERE
- uses: r-hub/actions/setup@v1
with:
config: ${{ github.event.inputs.config }}
id: rhub-setup

linux-containers:
needs: setup
if: ${{ needs.setup.outputs.containers != '[]' }}
runs-on: ubuntu-latest
name: ${{ matrix.config.label }}
strategy:
fail-fast: false
matrix:
config: ${{ fromJson(needs.setup.outputs.containers) }}
container:
image: ${{ matrix.config.container }}

steps:
- uses: r-hub/actions/checkout@v1
- uses: r-hub/actions/platform-info@v1
with:
token: ${{ secrets.RHUB_TOKEN }}
job-config: ${{ matrix.config.job-config }}
- uses: r-hub/actions/setup-deps@v1
with:
token: ${{ secrets.RHUB_TOKEN }}
job-config: ${{ matrix.config.job-config }}
- uses: r-hub/actions/run-check@v1
with:
token: ${{ secrets.RHUB_TOKEN }}
job-config: ${{ matrix.config.job-config }}

other-platforms:
needs: setup
if: ${{ needs.setup.outputs.platforms != '[]' }}
runs-on: ${{ matrix.config.os }}
name: ${{ matrix.config.label }}
strategy:
fail-fast: false
matrix:
config: ${{ fromJson(needs.setup.outputs.platforms) }}

steps:
- uses: r-hub/actions/checkout@v1
- uses: r-hub/actions/setup-r@v1
with:
job-config: ${{ matrix.config.job-config }}
token: ${{ secrets.RHUB_TOKEN }}
- uses: r-hub/actions/platform-info@v1
with:
token: ${{ secrets.RHUB_TOKEN }}
job-config: ${{ matrix.config.job-config }}
- uses: r-hub/actions/setup-deps@v1
with:
job-config: ${{ matrix.config.job-config }}
token: ${{ secrets.RHUB_TOKEN }}
- uses: r-hub/actions/run-check@v1
with:
job-config: ${{ matrix.config.job-config }}
token: ${{ secrets.RHUB_TOKEN }}
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: RMariaDB
Title: Database Interface and MariaDB Driver
Version: 1.3.2.9012
Version: 1.3.2.9900
Authors@R: c(
person("Kirill", "Müller", , "[email protected]", role = c("aut", "cre"),
comment = c(ORCID = "0000-0002-1416-3412")),
Expand Down
146 changes: 3 additions & 143 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,154 +1,14 @@
<!-- NEWS.md is maintained by https://fledge.cynkra.com, contributors should not edit this file -->

# RMariaDB 1.3.2.9012 (2024-11-18)

## Continuous integration

- Remove Aviator.

- Use stable pak (#349).

- Import from actions-sync, check carefully (#348).

- Use pkgdown branch (#347).

- ci: Use pkgdown branch

- ci: Updates from duckdb

- ci: Trigger run

- ci: Trigger run

- ci: Latest changes

- chore: Auto-update from GitHub Actions

Run: https://github.com/r-dbi/RMariaDB/actions/runs/11753599313


# RMariaDB 1.3.2.9011 (2024-09-15)

## Continuous integration

- Install via R CMD INSTALL ., not pak (#346).

- ci: Install via R CMD INSTALL ., not pak

- ci: Bump version of upload-artifact action


# RMariaDB 1.3.2.9010 (2024-09-04)

## Features

- Add back SSL support for MariaDB 5.5.68 (@d-hansen, #336, #338).

## Continuous integration

- Bump MariaDB version to fix checks (#344).


# RMariaDB 1.3.2.9009 (2024-08-31)

## Continuous integration

- Install local package for pkgdown builds.

- Improve support for protected branches with fledge.

- Improve support for protected branches, without fledge.


# RMariaDB 1.3.2.9008 (2024-08-17)

## Chore

- Auto-update from GitHub Actions.

Run: https://github.com/r-dbi/RMariaDB/actions/runs/10425483372

## Continuous integration

- Sync with latest developments.


# RMariaDB 1.3.2.9007 (2024-08-10)

## Continuous integration

- Use v2 instead of master.


# RMariaDB 1.3.2.9006 (2024-08-06)

## Continuous integration

- Inline action.


# RMariaDB 1.3.2.9005 (2024-08-02)

## Chore

- Auto-update from GitHub Actions.

Run: https://github.com/r-dbi/RMariaDB/actions/runs/10208511607

## Continuous integration

- Use dev roxygen2 and decor.


# RMariaDB 1.3.2.9004 (2024-07-10)
# RMariaDB 1.3.2.9900 (2024-11-18)

## Bug fixes

- `dbQuoteIdentifier()` removes the `def` catalog component again, regression introduced in RMariaDB 1.3.1 (#337, #339).

## Features

# RMariaDB 1.3.2.9003 (2024-07-02)

## Continuous integration

- Fix on Windows, tweak lock workflow.


# RMariaDB 1.3.2.9002 (2024-06-30)

## Chore

- Auto-update from GitHub Actions.

Run: https://github.com/r-dbi/RMariaDB/actions/runs/9728433906


# RMariaDB 1.3.2.9001 (2024-06-28)

## Chore

- Auto-update from GitHub Actions.

Run: https://github.com/r-dbi/RMariaDB/actions/runs/9692458109

## Continuous integration

- Avoid checking bashisms on Windows.

- Allow NOTEs on R-devel.

- Better commit message.

- Bump versions, better default, consume custom matrix.

- Recent updates.

- Prepare for dynamic check matrix.


# RMariaDB 1.3.2.9000 (2024-05-26)

- Merge branch 'cran-1.3.2'.
- Add back SSL support for MariaDB 5.5.68 (@d-hansen, #336, #338).


# RMariaDB 1.3.2 (2024-05-26)
Expand Down
20 changes: 3 additions & 17 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,19 +1,5 @@
RMariaDB 1.3.2
RMariaDB 1.3.2.9900

## R CMD check results
## Cran Repository Policy

- [x] Checked locally, R 4.3.3
- [x] Checked on CI system, R 4.4.0
- [x] Checked on win-builder, R devel

## Current CRAN check results

- [x] NOTE: r-devel-linux-x86_64-debian-clang, r-devel-linux-x86_64-debian-gcc, r-devel-linux-x86_64-fedora-clang, r-devel-linux-x86_64-fedora-gcc, r-devel-windows-x86_64
File ‘RMariaDB/libs/RMariaDB.so’:
Found non-API calls to R: ‘SETLENGTH’, ‘SET_TRUELENGTH’

Compiled code should not call non-API entry points in R.

See ‘Writing portable packages’ in the ‘Writing R Extensions’ manual.

Upstream problem, can't fix.
- [x] Reviewed CRP last edited 2024-08-27.

0 comments on commit 6c2a299

Please sign in to comment.