fix test skips

r-dbi · Dec 22, 2023 · 5f36103 · 5f36103
1 parent fd4a193
commit 5f36103
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/R/dbBind_AdbiResult.R b/R/dbBind_AdbiResult.R
@@ -20,7 +20,7 @@ dbBind_AdbiResult <- function(res, params, ...) {
   }
 
   if (is.list(params) && !inherits(params, "data.frame")) {
-    params <- as.data.frame(params, fix.empty.names = FALSE)
+    params <- as.data.frame(lapply(params, I), fix.empty.names = FALSE)
   }
 
   if (!isTRUE(meta(res, "prepared"))) {

diff --git a/R/dbColumnInfo_AdbiResult.R b/R/dbColumnInfo_AdbiResult.R
@@ -21,7 +21,7 @@ dbColumnInfo_AdbiResult <- function(res, ...) {
   data.frame(
     name = names(ret),
     type = vapply(ret, `[[`, character(1L), "type"),
-    storage_type = vapply(ret, `[[`, character(1L), "storage_type"),
+    .storage_type = vapply(ret, `[[`, character(1L), "storage_type"),
     row.names = NULL
   )
 }

diff --git a/R/nanoarrow.R b/R/nanoarrow.R
@@ -8,6 +8,8 @@ infer_nanoarrow_schema.AsIs <- function(x, ...) {
 #' @export
 infer_nanoarrow_schema.list <- function(x, ...) {
 
+  x[vapply(x, is.null, logical(1))] <- list(as.raw(NULL))
+
   is_raw <- vapply(x, is.raw, logical(1))
 
   if (!all(is_raw)) {

diff --git a/tests/testthat/test-DBItest.R b/tests/testthat/test-DBItest.R
@@ -43,9 +43,6 @@ if (identical(Sys.getenv("NOT_CRAN"), "true") &&
 
       # misc issues with poorly understood causes
       "append_table_new", # SQL error
-      "column_info",
-      "bind_raw",
-      "arrow_bind_raw",
       "bind_factor", # no warnings?
       "arrow_bind_factor", # no warnings?
       "read_table_empty",