rm some skips

r-dbi · Nov 24, 2023 · 8195fd6 · 8195fd6
1 parent 94da3df
commit 8195fd6
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 12 deletions.
diff --git a/R/dbDataType_AdbiConnection.R b/R/dbDataType_AdbiConnection.R
@@ -4,7 +4,9 @@
 dbDataType_AdbiConnection <- function(dbObj, obj, ...) {
   tryCatch(
     callNextMethod(...),
-    error = function(e) testthat::skip("Not yet implemented: dbDataType(Connection)")
+    error = function(e) {
+      testthat::skip("Not yet implemented: dbDataType(Connection)")
+    }
   )
 }
 #' @rdname DBI

diff --git a/R/dbDataType_AdbiDriver.R b/R/dbDataType_AdbiDriver.R
@@ -5,7 +5,9 @@ dbDataType_AdbiDriver <- function(dbObj, obj, ...) {
   # Optional: Can remove this if all data types conform to SQL-92
   tryCatch(
     callNextMethod(...),
-    error = function(e) testthat::skip("Not yet implemented: dbDataType(Driver)")
+    error = function(e) {
+      testthat::skip("Not yet implemented: dbDataType(Driver)")
+    }
   )
 }
 #' @rdname DBI

diff --git a/tests/testthat/helper-DBItest.R b/tests/testthat/helper-DBItest.R
@@ -1,5 +1,5 @@
 DBItest::make_context(
-  adbi("adbcsqlite"),
+  adbi::adbi("adbcsqlite"),
   list(
     uri = tempfile("DBItest", fileext = ".sqlite")
   ),
@@ -11,7 +11,7 @@ DBItest::make_context(
       date_cast = function(x) paste0("'", x, "'"),
       time_cast = function(x) paste0("'", x, "'"),
       timestamp_cast = function(x) paste0("'", x, "'"),
-      logical_return = function(x) as.numeric(x), # apache/arrow-adbc#1005
+      logical_return = function(x) bit64::as.integer64(x),
       date_typed = FALSE,
       time_typed = FALSE,
       timestamp_typed = FALSE,

diff --git a/tests/testthat/test-DBItest.R b/tests/testthat/test-DBItest.R
@@ -4,18 +4,14 @@ if (identical(Sys.getenv("NOT_CRAN"), "true") &&
   DBItest::test_all(
     skip = c(
       "package_name",
-      "connect_bigint_integer",
-      "connect_bigint_numeric",
-      "connect_bigint_character",
-      "connect_bigint_integer64",
+      "connect_bigint_integer", # not compliant with silent overflow
+      "connect_bigint_numeric", # not compliant with silent rounding
+      "connect_bigint_character", # arrow-nanoarrow#324
+      "data_logical", # r-dbi/DBItest/issues/308
       "send_query_stale_warning",
       "send_statement_stale_warning",
       "send_query_only_one_result_set",
       "send_statement_only_one_result_set",
-      "data_logical",
-      "data_raw", # apache/arrow-adbc#1004
-      "data_64_bit_numeric_warning", # apache/arrow-adbc#1005
-      "data_64_bit_lossless", # apache/arrow-adbc#1005
       "quote_identifier_string",
       "create_table_visible_in_other_connection",
       "table_visible_in_other_connection", # apache/arrow-adbc#1008