-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically add .lintr to .Rbuildignore by the use_lintr
function
#1895
Open
eitsupi
wants to merge
14
commits into
r-lib:main
Choose a base branch
from
eitsupi:buildignore-dotlintr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e20b398
add usethis to Suggests
eitsupi e89ca5d
add fs to Suggests
eitsupi 29b8ebf
If available, add .lintr file path to .Rbuildignore
eitsupi 780cb2b
add test
eitsupi a9e8be3
update test for not to use usethis
eitsupi efe56d1
remove usethis and fs functions
eitsupi b0f93e3
fix test
eitsupi 465a5b2
fix
eitsupi b83f045
Revert "fix"
eitsupi 589e526
Revert "fix test"
eitsupi b496bfb
Revert "remove usethis and fs functions"
eitsupi 9bbfb99
fix test
eitsupi 299a2e6
Merge branch 'main' into buildignore-dotlintr
eitsupi 7f5ae47
Merge branch 'main' into buildignore-dotlintr
IndrajeetPatil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
# use_lintr add .lintr to .Rbuildignore for packages | ||
|
||
Code | ||
cat(brio::read_file(file.path(tmp_package_dir, ".Rbuildignore"))) | ||
Output | ||
^lintr\.Rproj$ | ||
^\.Rproj\.user$ | ||
^\.lintr$ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test looks in the current working directory, not where the config was placed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is no guarantee that
DESCRIPTION
and.lintr
will be placed in the same directory, I believe that the current working directory can should be used.