Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new option to skip URLs in paste_linter for file paths #2092

Merged
merged 6 commits into from
Sep 7, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Closes #2082

@AshesITR
Copy link
Collaborator

AshesITR commented Aug 25, 2023

The argument name is very long.
WDYT about allow_file_path_url or changing allow_file_path = c("never", "double_slash", "always") with TRUE and FALSE being treated as "always" and "never" respectively?

@MichaelChirico
Copy link
Collaborator Author

allow_file_path = c("never", "double_slash", "always")

This LGTM, I didn't like needing two arguments around file paths & this seems like a natural way to control the linting of paths in one place 👍

@MichaelChirico
Copy link
Collaborator Author

TRUE and FALSE being treated as "always" and "never" respectively?

Since this hasn't been part of a release yet, I'll drop the option to have TRUE/FALSE, I'd rather keep it simple.

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2023

Codecov Report

Merging #2092 (839be6e) into main (bfff3d9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 839be6e differs from pull request most recent head 9f5da22. Consider uploading reports for the commit 9f5da22 to get more accurate results

@@           Coverage Diff           @@
##             main    #2092   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files         119      119           
  Lines        5227     5228    +1     
=======================================
+ Hits         5209     5210    +1     
  Misses         18       18           
Files Changed Coverage Δ
R/paste_linter.R 100.00% <100.00%> (ø)

@MichaelChirico MichaelChirico merged commit 3592898 into main Sep 7, 2023
21 checks passed
@MichaelChirico MichaelChirico deleted the paste-url branch September 7, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

paste_linter() should ignore URL-like paths for file.path() recommendation by default
3 participants