Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed_regex_linter is pipe-aware #2094

Merged
merged 7 commits into from
Aug 24, 2023
Merged

fixed_regex_linter is pipe-aware #2094

merged 7 commits into from
Aug 24, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Closes #1811

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023

Codecov Report

Merging #2094 (45abd45) into main (720c18e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 45abd45 differs from pull request most recent head 6a3cfc8. Consider uploading reports for the commit 6a3cfc8 to get more accurate results

@@           Coverage Diff           @@
##             main    #2094   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files         117      117           
  Lines        5145     5158   +13     
=======================================
+ Hits         5127     5140   +13     
  Misses         18       18           
Files Changed Coverage Δ
R/fixed_regex_linter.R 100.00% <100.00%> (ø)

Copy link
Collaborator

@AshesITR AshesITR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe add a test for |>?

@MichaelChirico
Copy link
Collaborator Author

Good catch. Basically the same amount of code to factorialize the test & cover all pipes, so did that while we're at it.

@MichaelChirico MichaelChirico merged commit c21600a into main Aug 24, 2023
@MichaelChirico MichaelChirico deleted the fre-pipe branch August 24, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fixed_regex_linter() throws false positives for piped-in stringr calls
3 participants