Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to opt out of linting filter() in conjunct_test_linter #2110

Merged
merged 6 commits into from
Sep 6, 2023
Merged

Allow to opt out of linting filter() in conjunct_test_linter #2110

merged 6 commits into from
Sep 6, 2023

Conversation

salim-b
Copy link
Contributor

@salim-b salim-b commented Sep 5, 2023

Fixes #2108.

@salim-b salim-b mentioned this pull request Sep 5, 2023
Closed
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2023 •
edited
Loading

Codecov Report

Merging #2110 (ab3b910) into main (02732a2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head ab3b910 differs from pull request most recent head 88734f3. Consider uploading reports for the commit 88734f3 to get more accurate results

@@           Coverage Diff           @@
##             main    #2110   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files         118      118           
  Lines        5208     5210    +2     
=======================================
+ Hits         5190     5192    +2     
  Misses         18       18
Files Changed Coverage Δ
R/conjunct_test_linter.R 100.00% <100.00%> (ø)

@MichaelChirico
Copy link
Collaborator

MichaelChirico commented Sep 6, 2023 •
edited
Loading

Thanks!

Please also

  1. add regression tests
  2. extend the NEWS item to mention this option & cite yourself

MichaelChirico
MichaelChirico reviewed Sep 6, 2023
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
MichaelChirico
MichaelChirico reviewed Sep 6, 2023
View reviewed changes
R/conjunct_test_linter.R Outdated
@@ -32,6 +33,14 @@
#' linters = conjunct_test_linter(allow_named_stopifnot = FALSE)
#' )
#'
#' lint(
#' text = "dplyr::filter(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the toil -- would you mind putting this into an inline expression? it'll be more consistent with examples from other linters. Typically when examples run to >1 line we write the examples little differently (search for writeLines()), but I don't think it's necessary in this case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this? 88734f3

@MichaelChirico MichaelChirico merged commit 35f3344 into r-lib:main Sep 6, 2023
21 checks passed
@salim-b salim-b deleted the allow-filter branch September 6, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelChirico MichaelChirico MichaelChirico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

conjunct_test_linter: Allow to opt out of linting dplyr::filter()
3 participants
@salim-b @codecov-commenter @MichaelChirico