use Rd_db to handle logic of loading help #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2111 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 119 119
Lines 5228 5228
=======================================
Hits 5210 5210
Misses 18 18 |
AshesITR
reviewed
Sep 7, 2023
tests/testthat/test-linter_tags.R
Outdated
|
|
||
| lintr_db <- available_linters(exclude_tags = NULL) | ||
| lintr_db$package <- NULL | ||
| lintr_db$tags <- lapply(lintr_db$tags, function(x) if ("deprecated" %in% x) "deprecated" else sort(x)) | ||
| lintr_db <- lintr_db[order(lintr_db$linter), ] | ||
|
|
||
| expect_true(exists("linters", envir = help_env), info = "?linters exists") | ||
| expect_true("linters.Rd" %in% names(help_db)) |
AshesITR
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2002
Main advantages (1) robust to R implementation details like "how is help stored in a package" and (2) works when running under
pkgload::load_all()