-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mimic R-4 documentation for Usage #2189
Conversation
Is this worth doing given that it will require updates to all translations? I don't think the new comment is that much of an improvement. |
For consistency matters, I think it is. The actual question is: why was chosen for this format in the first place? It is only one string, and translations are of course very easy to alter - we now have LLMs that can do that for us if need be. Even if done manually, it's only a handful of translations. |
Sure, it's a handful of translations, but it means reaching out to all the existing translators to get updates. IMO, it's a change with only a small positive impact that is going to take a few hours of my and others time to coordinate. |
I can absolutely see that of course. It is indeed something small. I discussed creating this PR with @maelle in #2187, but it’s up to you what you do with it :) I’m also careful about investing my time, I really understand your POV. On the other hand, if small bugs/inconsistencies are often left as is, they accumulate to a lot of garbage at a certain point. I’m okay with any decision you make! |
Coming back to this with fresh eyes, I think this is worthwhile, but only in a minor release when we might introduce new translations, and will need to let existing translators know that their help is needed once again. |
Fixes r-lib#2187 Co-authored-by: Hadley Wickham <[email protected]>
Fixes #2187 - mimics the comments in Usage as seen in R-4 documentation.