Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates based on my recent experiences #2368

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Updates based on my recent experiences #2368

merged 3 commits into from
Nov 14, 2023

Conversation

hadley
Copy link
Member

@hadley hadley commented Nov 3, 2023

No description provided.

@hadley hadley requested a review from jennybc November 3, 2023 14:15
vignettes/how-to-update-released-site.Rmd Outdated Show resolved Hide resolved
vignettes/how-to-update-released-site.Rmd Outdated Show resolved Hide resolved
vignettes/how-to-update-released-site.Rmd Outdated Show resolved Hide resolved
"DESCRIPTION"
)

glue::glue("git checkout v{ver} -- {files}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like you still need to explicitly say to run that git command in the terminal.

I assume you checked/experienced this, but you can just put a whole folder there in git checkout? I think I always do this move with individual files 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reader of this doc can be assumed to understand that if I'm generating git code in R, they'll need to copy and paste it.

And yes, you can indeed checkout folders.

vignettes/how-to-update-released-site.Rmd Outdated Show resolved Hide resolved
vignettes/how-to-update-released-site.Rmd Show resolved Hide resolved
vignettes/how-to-update-released-site.Rmd Outdated Show resolved Hide resolved
vignettes/how-to-update-released-site.Rmd Show resolved Hide resolved
@hadley hadley merged commit 5a0a31f into main Nov 14, 2023
13 checks passed
@hadley hadley deleted the site-update-updates branch November 14, 2023 21:52
SebKrantz pushed a commit to SebKrantz/pkgdown that referenced this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants