Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #2030 (not creating links at line starts) while not breaking #2122, for most common use case #2374

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Conversation

pearsonca
Copy link
Contributor

@pearsonca pearsonca commented Nov 20, 2023

Issue #2030 was fixed by #2104, but then had to be reverted because the solution cause #2122.

This PR fixes the original issue, without introducing the problem in #2122, for the most common case: a <p>@user ... or <p>#123 issue ....

While other breaking edge cases exist (e.g., if someone has already embedded a <p>@user</p> inside an anchor tag or some such), those strike me as unlikely practically and, if they did become prevalent, indicating more fundamental refactor (e.g. to xpath-style approaches).

Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! To finish it off, can you please add a bullet to the top of NEWS.md? It should briefly describe the change and end with (@yourname, #issuenumber).

@pearsonca
Copy link
Contributor Author

Thanks! To finish it off, can you please add a bullet to the top of NEWS.md? It should briefly describe the change and end with (@yourname, #issuenumber).

Done - fast-forwarded to latest commit on main, then added a bullet at the top of NEWS.

@hadley hadley merged commit b04d5c9 into r-lib:main Mar 11, 2024
13 checks passed
@hadley
Copy link
Member

hadley commented Mar 11, 2024

Perfect, thanks!

SebKrantz pushed a commit to SebKrantz/pkgdown that referenced this pull request Jun 1, 2024
Fixes r-lib#2030 (not creating links at line starts) while not breaking r-lib#2122, for most common use case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants