Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cli functions #2378

Merged
merged 20 commits into from
Nov 30, 2023
Merged

Use cli functions #2378

merged 20 commits into from
Nov 30, 2023

Conversation

jayhesselberth
Copy link
Collaborator

Part of #2116

@jayhesselberth

This comment was marked as resolved.

R/build-articles.R Outdated Show resolved Hide resolved
@jayhesselberth

This comment was marked as resolved.

@jayhesselberth

This comment was marked as resolved.

@jayhesselberth
Copy link
Collaborator Author

I see this at the end of the build messages, both locally and on GHA. Not sure what is causing this.

Warning messages:
1: In readLines(con, warn = FALSE) :
  invalid input found on input connection '/home/runner/work/pkgdown/pkgdown/vignettes/test/file1a343d741e0a.html'
2: In readLines(con, warn = FALSE) :
  invalid input found on input connection '/home/runner/work/pkgdown/pkgdown/vignettes/test/file1a346eb856ed.html'

@hadley

This comment was marked as resolved.

@jayhesselberth
Copy link
Collaborator Author

jayhesselberth commented Nov 26, 2023

This is ready for review.

R/build-reference.R Outdated Show resolved Hide resolved
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! It's a big PR so I think it's best to keep up the momentum and get this merged as quickly as possible. We can add follow up issues/PRs for the more complicated stuff.

R/build-articles.R Outdated Show resolved Hide resolved
R/build-articles.R Outdated Show resolved Hide resolved
R/build-articles.R Outdated Show resolved Hide resolved
R/build-favicons.R Outdated Show resolved Hide resolved
R/build-favicons.R Outdated Show resolved Hide resolved
tests/testthat/_snaps/build-articles.md Outdated Show resolved Hide resolved
tests/testthat/_snaps/build-articles.md Show resolved Hide resolved
tests/testthat/_snaps/build-home-index.md Outdated Show resolved Hide resolved
tests/testthat/_snaps/build-logo.md Show resolved Hide resolved
tests/testthat/_snaps/build-reference.md Outdated Show resolved Hide resolved
@jayhesselberth
Copy link
Collaborator Author

These new errors are caused by subtle path differences on the different testing platforms, which fail because the snapshots are slightly different.

I can use expect_message() instead of expect_snapshot() in the failing tests, which works fine, but the actual message bleeds into the interactive testthat report, so I need to do suppressMessages(expect_message(...)), which can't be the best way to do this (though is effective).

@jayhesselberth jayhesselberth added this to the 2.0.8 milestone Nov 28, 2023
R/build-redirects.R Outdated Show resolved Hide resolved
R/utils-yaml.R Outdated Show resolved Hide resolved
R/utils-yaml.R Outdated Show resolved Hide resolved
R/build-redirects.R Outdated Show resolved Hide resolved
R/build-favicons.R Outdated Show resolved Hide resolved
R/build-favicons.R Outdated Show resolved Hide resolved
suppress messages during init_site() testing to account for path differences between testing platforms
@jayhesselberth
Copy link
Collaborator Author

@hadley one more round of review and this should be good to go.

that should be all of them, there are so many
R/build-articles.R Outdated Show resolved Hide resolved
R/build-favicons.R Outdated Show resolved Hide resolved
R/build-favicons.R Show resolved Hide resolved
R/build-favicons.R Outdated Show resolved Hide resolved
R/build-home-index.R Outdated Show resolved Hide resolved
R/rmarkdown.R Show resolved Hide resolved
R/rmarkdown.R Outdated Show resolved Hide resolved
R/rmarkdown.R Show resolved Hide resolved
R/rmarkdown.R Show resolved Hide resolved
tests/testthat/_snaps/build-articles.md Show resolved Hide resolved
@jayhesselberth jayhesselberth merged commit 13d8d62 into main Nov 30, 2023
13 checks passed
@jayhesselberth jayhesselberth deleted the cli-update branch November 30, 2023 13:56
SebKrantz pushed a commit to SebKrantz/pkgdown that referenced this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants