-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cli functions #2378
Use cli functions #2378
Conversation
Part of #2116
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I see this at the end of the build messages, both locally and on GHA. Not sure what is causing this.
|
This comment was marked as resolved.
This comment was marked as resolved.
need to check snapshots carefully
This is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! It's a big PR so I think it's best to keep up the momentum and get this merged as quickly as possible. We can add follow up issues/PRs for the more complicated stuff.
These new errors are caused by subtle path differences on the different testing platforms, which fail because the snapshots are slightly different. I can use |
suppress messages during init_site() testing to account for path differences between testing platforms
@hadley one more round of review and this should be good to go. |
that should be all of them, there are so many
Part of #2116