fix: use BS version from template package again #2441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now I also realize that if the pkgdown package template is used by a central docs building thing, it's not too hard to set the BS version in an override. 😅 |
Bisaloo
approved these changes
Apr 15, 2024
|
This section https://pkgdown.r-lib.org/articles/customise.html#template-packages states that one can use the configuration file of the template package to set the Bootstrap version. |
hadley
requested changes
Apr 15, 2024
| @@ -32,6 +32,9 @@ as_pkgdown <- function(pkg = ".", override = list()) { | |||
| ) | |||
| meta <- modify_list(template_config, meta) | |||
|
|
|||
| # BS version can also be set by template package itself | |||
| bs_version <- get_bootstrap_version(list(meta = meta)) | |||
There was a problem hiding this comment.
Given that this function is the only place that get_bootstrap_version() is used, I think it might be slightly clearer to do something like:
# Update bs_version if set in template
bs_version <- bs_version %||% template_config$bootstrap 
|
Thanks both!! |
SebKrantz
pushed a commit
to SebKrantz/pkgdown
that referenced
this pull request
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2440 cc @gadenbuie
@Bisaloo could you please confirm it also works for you?
This is not an elegant fix because of getting the BS version twice. I can also imagine it'd make sense to ask maintainers of template packages to ask their users to set the BS version? But it means more work if updating the BS version in the template package so I would not appreciate this outcome as a template package maintainer. 😹