Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish addin #2452

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Polish addin #2452

merged 4 commits into from
Apr 30, 2024

Conversation

hadley
Copy link
Member

@hadley hadley commented Apr 16, 2024

Fixes #2252

@hadley hadley requested a review from jennybc April 16, 2024 21:24
jennybc
jennybc approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@jennybc jennybc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you feel this way, then I definitely do!

Yeah, I don't see why it shouldn't just call build_site()

@hadley hadley merged commit 2806f61 into main Apr 30, 2024
12 checks passed
@hadley hadley deleted the addin branch April 30, 2024 23:39
SebKrantz pushed a commit to SebKrantz/pkgdown that referenced this pull request Jun 1, 2024
@hadley @SebKrantz
Polish addin (r-lib#2452)
f9240fe 
Fixes r-lib#2252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennybc jennybc jennybc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uninformative error (and/or problem with pkgdown:::build_site_external())
2 participants
@hadley @jennybc