Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish analytics docs #2456

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Polish analytics docs #2456

merged 3 commits into from
Apr 17, 2024

Conversation

hadley
Copy link
Member

@hadley hadley commented Apr 17, 2024

Fixes #2304

@juliasilge do you mind pointing me to the commit where you ended up implementing what you needed? Maybe I also need to update the google example?

@hadley hadley requested a review from juliasilge April 17, 2024 12:43
@hadley hadley changed the title Polish analytsics docs Polish analytics docs Apr 17, 2024
@juliasilge
Copy link
Member

R/build.R Outdated
#'
#' ```yaml
#' template:
#' templates:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should "templates" be plural here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope!

Copy link
Member

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that Google Tag Manager is not exactly the same thing as Google Analytics IIUC, and I'm not sure which is better to show in the docs. Pointing out before_body is the main thing that would have set me on the right path. 👍

@hadley hadley merged commit a33d9d3 into main Apr 17, 2024
12 checks passed
@hadley hadley deleted the analytics-docs branch April 17, 2024 21:24
SebKrantz pushed a commit to SebKrantz/pkgdown that referenced this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible to add another HTML option for analytics code?
2 participants