-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish analytics docs #2456
Polish analytics docs #2456
Conversation
|
R/build.R
Outdated
#' | ||
#' ```yaml | ||
#' template: | ||
#' templates: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should "templates" be plural here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that Google Tag Manager is not exactly the same thing as Google Analytics IIUC, and I'm not sure which is better to show in the docs. Pointing out before_body
is the main thing that would have set me on the right path. 👍
Fixes #2304
@juliasilge do you mind pointing me to the commit where you ended up implementing what you needed? Maybe I also need to update the google example?